chore: prune non-upgradeable network vats from production config #7165

dckc · 2023-03-14T07:07:48Z

closes: #7044

Description

reorg network / IBC bootstrap to avoid including vat-network in production config

Security Considerations

facilitates audit of production config

Scaling, Documentation Considerations

none AFAICT

Testing Considerations

TODO:

finish WIP commits
try the smoke tests

- confine ambient authority to test set-up region - fix some static typing

- update boot-psm.js now that manifest.js is gone - move BootstrapManifest type to lib-boot.js chore(vats): reorg boot-chain, chain-behaviors - restore test-boot.js tests - static types for test-boot.js and boot-*.js - prune argvByRole - no more export * - lib-boot: early check for missing behavior - basic-behaviors.js: - organize imports a bit - all behaviors return Promise<void> use await rather than return - export BASIC_BOOTSTRAP_PERMITS - boot-chain.js: - destructure non-behaviors out of import * - hoist modules - chain-behaviors: factor BASIC_BOOTSTRAP_PERMITS out of SHARED_CHAIN_BOOTSTRAP_MANIFEST

With an empty `modules` bootstrap power, `Cannot read properties of undefined (reading 'runModuleBehaviors')` ... was thrown in the code generated by makeWriteCoreProposal() in code-gen.js The initial symptoms were pretty obscure: ``` KERNEL PANIC: kp40.policy panic: rejected {"body":"#{\"#error\":\"behavior: cannot coerce undefined to object\" ``` These debug settings gave us a useful stack trace: `packages/solo/test$ DEBUG=SwingSet:ls,SwingSet:vat,track-turns ./startsolo.sh` The offending line is referring to `runModuleBehaviors` as a module global. So `Cannot read properties of undefined` seems to be SES-shim-speak for "Reference Error".

Patterned after devnet config, but uses boot-sim.js bootstrap vat. ```diff $ diff -wu ./decentral-devnet-config.json ./decentral-demo-config.json --- ./decentral-devnet-config.json 2023-02-24 14:02:56.015581229 -0600 +++ ./decentral-demo-config.json 2023-02-24 14:59:18.991084488 -0600 @@ -106,7 +106,7 @@ ], "vats": { "bootstrap": { - "sourceSpec": "@agoric/vats/src/core/boot-chain.js", + "sourceSpec": "@agoric/vats/src/core/boot-sim.js", "creationOptions": { "critical": true } ```

- export manifest from sim-behaviors.js - core(inter-protocol): static types for sim-behaviors - return Promise<void>

rather than ROLE

- misc static types - note TODO ideas - make executable

- toward test for non-upgradeable vats

No change to the runtime names, for now: vatParams.argv

- test: sim/demo config launches Vaults as expected by loadgen - demo-config: add missing proposals: - add-collateral-core for IbcATOM - price-feed-core - test: fill out expected home properties - installSimEgress: make hardcodedClientAddresses optional - type: prune governanceActions (obsolete in favor of coreProposals) - type: prune bootstrapManifest from BootstrapVatParams - no longer dynamic - rename USDC -> DAI in connectFaucet() - add missing harden()s in nameHub, connectFaucet() - factor out makeHomeFor()

to avoid making chainStorage vat until we need it

- no vat-network in prod - only in boot-sim (hm... not good enough for devnet) - coreProposals supports installations but not raw vats, so we're doing static config for now - split registerNetworkProtocols into client, chain cases

datadog-full-agoric · 2023-03-14T07:14:40Z

Datadog Report

Branch report: dc-net-not-prod
Commit report: 52a0e91

❌ agoric-sdk: 8 Failed (0 Known Flaky), 0 New Flaky, 2222 Passed, 25 Skipped, 16m 52.12s Wall Time

❌ Failed Tests (8)

This report shows up to 5 failed tests.

gov-collateral › assets are in Vaults - agoric.inter-protocol - Details

Expand for error

 ---
     name: AssertionError
     message: Rejected promise returned by test
     values:
       'Rejected promise returned by test. Reason:': |-
         TypeError {
           message: 'Cannot read properties of undefined (reading \'consume\')',
         }
     at: |-
       addBankAssets (packages/vats/src/core/basic-behaviors.js:263:21)
 ...

gov-collateral › Benefactor can add to reserve - agoric.inter-protocol - Details

Expand for error

 ---
     name: AssertionError
     message: Rejected promise returned by test
     values:
       'Rejected promise returned by test. Reason:': |-
         TypeError {
           message: 'Cannot read properties of undefined (reading \'consume\')',
         }
     at: |-
       addBankAssets (packages/vats/src/core/basic-behaviors.js:263:21)
 ...

gov-collateral › Committee can raise debt limit - agoric.inter-protocol - Details

Expand for error

 ---
     name: AssertionError
     message: Rejected promise returned by test
     values:
       'Rejected promise returned by test. Reason:': |-
         TypeError {
           message: 'Cannot read properties of undefined (reading \'consume\')',
         }
     at: |-
       addBankAssets (packages/vats/src/core/basic-behaviors.js:263:21)
 ...

gov-collateral › voters get invitations - agoric.inter-protocol - Details

Expand for error

 ---
     name: AssertionError
     message: Rejected promise returned by test
     values:
       'Rejected promise returned by test. Reason:': |-
         TypeError {
           message: 'Cannot read properties of undefined (reading \'consume\')',
         }
     at: |-
       addBankAssets (packages/vats/src/core/basic-behaviors.js:263:21)
 ...

addAsset › before hook - agoric.smart-wallet - Details

Expand for error

 ---
     name: AssertionError
     message: Rejected promise returned by test
     values:
       'Rejected promise returned by test. Reason:': |-
         TypeError {
           message: 'Cannot read properties of undefined (reading \'consume\')',
         }
     at: |-
       makeBoard (packages/vats/src/core/basic-behaviors.js:134:23)
 ...

michaelfig · 2023-03-14T15:30:08Z

packages/vats/src/core/basic-behaviors.js

@@ -317,14 +285,15 @@ export const addBankAssets = async ({
  bldIssuerKit.resolve(bldKit);

  const assetAdmin = E(agoricNamesAdmin).lookupAdmin('vbankAsset');
+  // XXX interposes bootstrap between agoricNames and vat-bank


@michaelfig: I'll be able to fix this one with the callback abstraction (a closureless bound method descriptor).

Seems to me that the simpler fix is to just pass assetAdmin and not bother with a separate updater. The only risk would be that vat-bank abuses .reserve().

michaelfig · 2023-03-14T15:51:00Z

packages/vats/src/core/startNetIBC.js

+    installations: {
+      provisionPool: restoreRef(installKeys.provisionPool),
+      walletFactory: restoreRef(installKeys.walletFactory),
+    },


I'm baffled as to why these installations are needed. Was this a typo?

dckc · 2023-05-06T02:42:09Z

obsolete in favor of #7623

dckc added 30 commits March 13, 2023 11:01

test(vats): factor out t.context.loadBundle()

f4386ef

- confine ambient authority to test set-up region - fix some static typing

test(solo): confine ambient authority to setup

409e1f2

test(vats): stub test for bootstrap upgrade

1727a57

refactor(vats): factor out lib-boot.js

714388a

refactor(vats): copy boot.js for chain, sim, solo

5f71000

WIP(inter-protocol): sim proposal getManifestForInterProtocol

1ab36c6

- export manifest from sim-behaviors.js - core(inter-protocol): static types for sim-behaviors - return Promise<void>

refactor(inter-protocol): BootstrapManifest type moved

00ab485

fix(solo)!: separate boot-solo.js out of boot.js (CONT.)

92c34f1

rather than ROLE

chore(vats): move authorityViz.js to tools

82e1b63

chore(vats): restore authorityViz.js to working order

8c1a23c

- misc static types - note TODO ideas - make executable

refactor(vats): factor out promise-space.js

414ec71

test(inter-protocol): update makePromiseSpace import

0485748

test(vats): parameterize config in makeSwingsetTestKit()

f058385

test(vats): bootstrap support for solo dev: home.myAddressNameAdmin

2ccc186

feat(vats): export makeAgoricNamesAccess at package level

bf2e5b5

test(vats): no test-only code is in production configs

fe8a027

- toward test for non-upgradeable vats

fix(vats): prune mints/faucet from prod-like vats config

b8f95d4

chore(vats): prune sharing vat from test-vaults-config

7b01d4b

chore: move sim stuff out of inter-protocol

01a28f6

chore(vats): clarify which vat bootstrap items go

3062bea

test(vats): bootstrap visualization snapshot

070ef30

test(vats): check production constraints on coreProposals

f238de7

docs(vats): document purpose etc. of config files

917c5c9

docs: bootstrapArgs is arbitrary JSON-serializable data

e076b56

No change to the runtime names, for now: vatParams.argv

chore: prune remaining uses of bootstrap sim/chain/client ROLE

244770c

chore: prune pegasus from test-vaults-config

bc5393b

dckc added 16 commits March 13, 2023 23:05

WIP: boot-psm: installations are all in the Zoe vat

ceca6da

WIP: more namedVat space

03aa3e8

refactor(vats): export manifest from boot-psm for static analysis

9d31094

test(vats): check produce vs consume in PSM manifest

f87d253

feat(vats): support namedVat space in authorityViz

b10317e

test(vats): update diagram snapshot

28daf63

docs(inter-protocol): static type for ECON_COMMITTEE_MANIFEST

9ffdf10

docs(vats): notes on Far usage in bootstrap vat

c2a6862

feat(vats): make extract() lazier (NEEDSTEST)

b9c6137

to avoid making chainStorage vat until we need it

chore(vats): namedVat space CONT.

fc0a6be

WIP: toward coreProposal for vat-network

cf28829

- no vat-network in prod - only in boot-sim (hm... not good enough for devnet) - coreProposals supports installations but not raw vats, so we're doing static config for now - split registerNetworkProtocols into client, chain cases

fixup: for PSM_MANIFEST type

c31dc19

fixup! docs(vats): notes on Far usage in bootstrap vat

d4abd9a

docs(vats): walletFactory config doesn't seem to be optional

4421ec3

test(vats): no-proposals tests are noop (WIP)

94deb6a

docs(vats): debugging note

43e2940

dckc mentioned this pull request Mar 14, 2023

production bootstrap vat includes sim-chain tools such as connectFaucet #6687

Closed

2 tasks

michaelfig reviewed Mar 14, 2023

View reviewed changes

dckc added 5 commits March 14, 2023 11:26

fixup! test(vats): check produce vs consume in PSM manifest

c3f8359

fixup! test(vats): check produce vs consume in PSM manifest

ffd5dd7

test(vats): audit MANIFEST from boot-chain.js

c55342a

fixup! chore(vats): namedVat space CONT.

1a695db

fixup! WIP: toward coreProposal for vat-network

77bcf02

dckc mentioned this pull request Apr 10, 2023

all vats that will be deployed in Vaults Release must be upgradable #6553

Closed

dckc force-pushed the dc-no-centralSupply branch 2 times, most recently from 1801440 to 2f44599 Compare May 1, 2023 21:17

dckc closed this May 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: prune non-upgradeable network vats from production config #7165

chore: prune non-upgradeable network vats from production config #7165

dckc commented Mar 14, 2023

datadog-full-agoric bot commented Mar 14, 2023 •

edited

Loading

michaelfig Mar 14, 2023

dckc Mar 14, 2023

michaelfig Mar 14, 2023

dckc Mar 14, 2023

dckc commented May 6, 2023

chore: prune non-upgradeable network vats from production config #7165

chore: prune non-upgradeable network vats from production config #7165

Conversation

dckc commented Mar 14, 2023

Description

Security Considerations

Scaling, Documentation Considerations

Testing Considerations

datadog-full-agoric bot commented Mar 14, 2023 • edited Loading

Datadog Report

❌ Failed Tests (8)

michaelfig Mar 14, 2023

Choose a reason for hiding this comment

dckc Mar 14, 2023

Choose a reason for hiding this comment

michaelfig Mar 14, 2023

Choose a reason for hiding this comment

dckc Mar 14, 2023

Choose a reason for hiding this comment

dckc commented May 6, 2023

datadog-full-agoric bot commented Mar 14, 2023 •

edited

Loading