Durable vat-bank and virtual-purse #7617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfig
force-pushed
the
mfig-upgradable-bank
branch
3 times, most recently
from
d969dd8
to
9ab9dde
Compare
michaelfig
force-pushed
the
mfig-upgradable-bank
branch
from
62b3a1e
to
453f4d1
Compare
…kSet` etc are replaced
turadg
approved these changes
May 7, 2023
michaelfig
force-pushed
the
mfig-upgradable-bank
branch
from
d0c6811
to
0091ee1
Compare
michaelfig
force-pushed
the
mfig-upgradable-bank
branch
from
0091ee1
to
18a3395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #5885
refs: #7633
Description
This is the first version of the vat-bank durablization that passes existing tests, and that I assert is "reachably durable". I'd like to land these changes as a basis for upgrade testing and incremental improvements to vat-bank after the fact.
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
This has not yet gone through a vat restart (null-upgrade) test. We should do that before declaring it "upgradable".
getAssetSubscriptionwas manually tested to ensure that new clients indeed receive the full asset history. It also needs to be tested across restarts to ensure newly added assets interact well with the resume-on-upgrade feature ofsubscribeEach. The publicationCounts used by each incarnation are intended to be deterministic, and the historical data is durable.