chore: Sync Endo #8651
chore: Sync Endo #8651
Conversation
| getRoundData: M.call(M.any()).returns(M.promise()), | ||
| getRoundStatus: M.call(M.any()).returns(M.record()), | ||
| oracleRoundStateSuggestRound: M.call(M.any()).returns(M.record()), | ||
| authenticateQuote: M.call().rest(M.any()).returns(M.any()), |
There was a problem hiding this comment.
This should take one quote,
agoric-sdk/packages/zoe/tools/manualPriceAuthority.js
Lines 39 to 45 in a271af9
I'll push accurate guards.
There was a problem hiding this comment.
Better guards would certainly be nice, but can happen after this PR. Thus, I won't withhold approval waiting for this conversation to be resolved.
There was a problem hiding this comment.
refactor: Make all TS import extensions explicit
Why?
There was a problem hiding this comment.
Tsc made me do it. I do not know why tsc insisted, but it did.
| * @typedef {import('@agoric/time').RelativeTime} RelativeTime // TODO: use | ||
| * RelativeTime, not RelativeTimeValue |
There was a problem hiding this comment.
this TODO is odd. perhaps it's meant to be a deprecated type?
| @@ -89,6 +89,10 @@ export const makeDurableZone = (baggage, baseLabel = 'durableZone') => { | |||
| /** @type {import('.').Zone['exoClass']} */ | |||
| const exoClass = (...args) => prepareExoClass(baggage, ...args); | |||
| /** @type {import('.').Zone['exoClassKit']} */ | |||
| // @ts-ignore This type check regressed inexplicably with the release | |||
There was a problem hiding this comment.
I'll take a look at fixing this before approving
There was a problem hiding this comment.
Likewise, although it would be nice to get this resolved now, it can happen after this PR, so I won't withhold approval waiting for it.
package.json
Outdated
| @@ -10,7 +10,7 @@ | |||
| "type": "module", | |||
| "packageManager": "[email protected]", | |||
| "devDependencies": { | |||
| "@endo/eslint-plugin": "^0.5.1", | |||
| "@endo/eslint-plugin": "^1.0.0", | |||
There was a problem hiding this comment.
these 1.0s, will they all be semver? Are Endo maintainers committed to major very bump for all breaking changes? do deep imports count as the package API?
There was a problem hiding this comment.
Deep imports are expressly forbidden by an "exports" directive in every public Endo package except captp, far, lockdown, and marshal, and these must be fixed.
Endo has for some time committed to backward-compatibility for dependents using the default carat (^) range, which is more strict than semver.
There was a problem hiding this comment.
Tracking the broader issue for Agoric SDK #8679
Wow, that's a long time ago! |
kriskowal
force-pushed
the
kris-sync-endo-2023-12-12-20-31-15
branch
8 times, most recently
from
3d3a6f3
to
89c2b4b
Compare
| getRoundData: M.call(M.any()).returns(M.promise()), | ||
| getRoundStatus: M.call(M.any()).returns(M.record()), | ||
| oracleRoundStateSuggestRound: M.call(M.any()).returns(M.record()), | ||
| authenticateQuote: M.call().rest(M.any()).returns(M.any()), |
There was a problem hiding this comment.
Better guards would certainly be nice, but can happen after this PR. Thus, I won't withhold approval waiting for this conversation to be resolved.
| @@ -89,6 +89,10 @@ export const makeDurableZone = (baggage, baseLabel = 'durableZone') => { | |||
| /** @type {import('.').Zone['exoClass']} */ | |||
| const exoClass = (...args) => prepareExoClass(baggage, ...args); | |||
| /** @type {import('.').Zone['exoClassKit']} */ | |||
| // @ts-ignore This type check regressed inexplicably with the release | |||
There was a problem hiding this comment.
Likewise, although it would be nice to get this resolved now, it can happen after this PR, so I won't withhold approval waiting for it.
kriskowal
force-pushed
the
kris-sync-endo-2023-12-12-20-31-15
branch
from
89c2b4b
to
69884dd
Compare
This change brings Agoric SDK in sync with the latest versions from Endo as of December 12, 2023.
This includes syncing up breaking changes with interface guards. Where invalid call guards would silently allow an invocation previously, they now throw. Several interface guards needed fixing.
Some accommodations were necessary for the new
__getMethodNames__and__getInterfaceGuard__protocols.The algorithm for performing a speculative integration with an Endo branch required an adjustment to ensure that types were generated correctly.
For reasons opaque to the integrator, this required:
.jsextension. The only relevant change from the Endo side is that many packages provide generated.d.tstypes now.to have atypesfield pointing atindex.js`, which by dint of fortunate coïncidence is a valid TypeScript definition file.@agoric/zonethat only causes a type error in integration with@agoric/vats.