Endo sync types #8688
Merged
Endo sync types #8688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
force-pushed
the
ta/fixup-endo-sync
branch
from
3e00ed3
to
91693ba
Compare
kriskowal
approved these changes
Dec 21, 2023
Used only for the defineKind* methods, which are already deprecated
turadg
force-pushed
the
ta/fixup-endo-sync
branch
from
91693ba
to
990a79d
Compare
michaelfig
reviewed
Dec 22, 2023
| @@ -14,8 +14,8 @@ const ownKeys = | |||
| ); | |||
|
|
|||
| /** | |||
| * @template T | |||
| * @typedef {(...args: Parameters<ReturnType<prepareAttenuator>>) => Farable<T>} MakeAttenuator | |||
| * @template {import('@endo/exo/src/exo-makers.js').Methods} T | |||
There was a problem hiding this comment.
What would it take to make the following work?
Suggested change
| * @template {import('@endo/exo/src/exo-makers.js').Methods} T | |
| * @template {import('@endo/exo').Methods} T |
There was a problem hiding this comment.
A release of Endo that exported the types at the root. I assume Endo maintainers haven't done this yet because they haven't decided on a stable set of type exports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #8651
Description
The recent Endo sync had many hurdles so some were deferred to land it. One was a types regression.
This fixes that by importing the Endo types where appropriate. It also improves the accuracy of the Exo helpers in vat-data by guarding the
this.facets.Security Considerations
n/a
Scaling Considerations
n/a
Documentation Considerations
n/a
Testing Considerations
CI
Upgrade Considerations
roundsManagernow has a tighter runtime check. It describes the actual interface so it should be backwards compatible.