fix(vm-config): always use init-localchain and init-transfer
#9672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
9b317a0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://391de217.agoric-sdk.pages.dev |
| Branch Preview URL: | https://mfig-update-swingset-configs.agoric-sdk.pages.dev |
0xpatrickdev
reviewed
Jul 9, 2024
| "@agoric/builders/scripts/pegasus/init-core.js", | ||
| "@agoric/builders/scripts/vats/init-transfer.js" | ||
| "@agoric/builders/scripts/vats/init-localchain.js", | ||
| "@agoric/builders/scripts/vats/init-transfer.js" |
There was a problem hiding this comment.
Suggested change
| "@agoric/builders/scripts/vats/init-transfer.js" | |
| "@agoric/builders/scripts/vats/init-transfer.js" |
turadg
requested changes
Jul 9, 2024
|
Is the problem here that there are no config that does both orch core and inter protocol ? I believe the need is for networks like devnet |
turadg
approved these changes
Jul 9, 2024
michaelfig
force-pushed
the
mfig-update-swingset-configs
branch
from
4015084
to
03538ea
Compare
michaelfig
force-pushed
the
mfig-update-swingset-configs
branch
from
03538ea
to
9b317a0
Compare
gibson042
pushed a commit
that referenced
this pull request
Jul 9, 2024
## Description While working on orchnet, I discovered that `decentral-itest-vaults-config.json` lacked references to the `init-localchain.js` and `init-transfer.js` core-evals. This PR: - enables them for future chains, since we intend to use them wherever `init-network.js` is present - removes config references to Pegasus, since it is an obsolete demonstration of an IBC contract, and now we have newer and better examples, - reduces loud warnings from `vat-bank.js` when unregistered asset balances were detected, since we expect this to be commonplace when dealing with IBC assets from many chains ### Security Considerations n/a ### Scaling Considerations Less logging from `vat-bank.js`, once it is upgraded (or started on a new chain). ### Testing Considerations ### Upgrade Considerations The `vat-bank.js` changes do not modify functionality except logging, so I consider it safe to include for future chains without requiring mainnet's bank vat to be upgraded.
gibson042
added a commit
that referenced
this pull request
Jul 10, 2024
## Description Includes commits from the following PRs: * #9671 * #9672 ...plus a new commit introducing upgrade name "agoric-upgrade-16-2". Constructed using the following `git rebase -i HEAD` todo list: ``` # pull request #9671 # resolve conflicts by: # * `git rm packages/orchestration/test/supports.ts` # * in packages/vats/src/proposals/transfer-proposal.js, take the proposed imports # * in packages/vats/test/localchain.test.js, leave `import { NonNullish } from '@agoric/assert'` # but take the VTRANSFER_IBC_EVENT change pick 217005a fix: adopt `VTRANSFER_IBC_EVENT` as an action-type (#9671) # pull request #9672 branch mfig-update-swingset-configs label base-mfig-update-swingset-configs pick 870d205 fix(vm-config): always use `init-localchain` and `init-transfer` pick 236a3f0 chore(vm-config): remove obsolete `pegasus/init-core.js` pick 7f7a8bd chore(bank): demote noisy logs to `debug` level pick 9b317a0 docs: purpose of itest-vaults config label mfig-update-swingset-configs reset base-mfig-update-swingset-configs merge -C 8f019c0 mfig-update-swingset-configs # fix(vm-config): always use `init-localchain` and `init-transfer` (#9672) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on orchnet, I discovered that
decentral-itest-vaults-config.jsonlacked references to theinit-localchain.jsandinit-transfer.jscore-evals.This PR:
init-network.jsis presentvat-bank.jswhen unregistered asset balances were detected, since we expect this to be commonplace when dealing with IBC assets from many chainsSecurity Considerations
n/a
Scaling Considerations
Less logging from
vat-bank.js, once it is upgraded (or started on a new chain).Testing Considerations
Upgrade Considerations
The
vat-bank.jschanges do not modify functionality except logging, so I consider it safe to include for future chains without requiring mainnet's bank vat to be upgraded.