chore: More upgrade-16 cherry-picks #9675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes: #9670 Ensure that the `VTRANSFER_IBC_EVENT` messages are plumbed through the `cosmic-swingset` layer. Prevents chain halt when the `x/vtransfer` facilities are used. This bug was overlooked because end-to-end testing of this facility was not completed until a late stage. Earlier unit testing used mocks of the bridge device that did not have the same problematic behaviour. More automated end-to-end IBC testing in a close-to-production setting is needed. Fixing this `cosmic-swingset` behaviour does not require upgrade of any other components.
## Description While working on orchnet, I discovered that `decentral-itest-vaults-config.json` lacked references to the `init-localchain.js` and `init-transfer.js` core-evals. This PR: - enables them for future chains, since we intend to use them wherever `init-network.js` is present - removes config references to Pegasus, since it is an obsolete demonstration of an IBC contract, and now we have newer and better examples, - reduces loud warnings from `vat-bank.js` when unregistered asset balances were detected, since we expect this to be commonplace when dealing with IBC assets from many chains ### Security Considerations n/a ### Scaling Considerations Less logging from `vat-bank.js`, once it is upgraded (or started on a new chain). ### Testing Considerations ### Upgrade Considerations The `vat-bank.js` changes do not modify functionality except logging, so I consider it safe to include for future chains without requiring mainnet's bank vat to be upgraded.
gibson042
changed the title
Deploying agoric-sdk with
|
| Latest commit: |
df59ce3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://00fc3f07.agoric-sdk.pages.dev |
| Branch Preview URL: | https://gibson-upgrade-16-rc2-cherry.agoric-sdk.pages.dev |
mhofman
approved these changes
Jul 9, 2024
This was referenced Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Includes commits from the following PRs:
VTRANSFER_IBC_EVENTas an action-type #9671init-localchainandinit-transfer#9672...plus a new commit introducing upgrade name "agoric-upgrade-16-2".
Constructed using the following
git rebase -i HEADtodo list: