config lint to harden exports #9734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
c893bb2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://96cbe848.agoric-sdk.pages.dev |
| Branch Preview URL: | https://9693-lint-exports.agoric-sdk.pages.dev |
turadg
force-pushed
the
9693-lint-exports
branch
from
3bc616e
to
d8312d5
Compare
turadg
force-pushed
the
9693-lint-exports
branch
2 times, most recently
from
90737d1
to
3a3e390
Compare
turadg
force-pushed
the
9693-lint-exports
branch
from
3a3e390
to
5d261de
Compare
0xpatrickdev
approved these changes
Aug 12, 2024
|
I think we missed ~6 objects that need hardening in the course of |
Those aren't module level exports. I think it's a testing issue but let's discuss what to do about it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9693
Description
more linting for #9693, using endojs/endo#2369
Also adopts
harden-exportsfor.contract.jsmodules,Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
CI with expected errors
Upgrade Considerations
n/a