harden-exports rule for eslint plugin #2369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kriskowal
approved these changes
Jul 18, 2024
Comment on lines
+81
to
+82
| export const a = 'alreadyHardened'; | ||
| export const b = 'toHarden'; |
There was a problem hiding this comment.
In a handful of cases, it will be somewhat tedious to have to harden primitive literals. Are you up for a little complication?
There was a problem hiding this comment.
I'm all ears. I'd like to land this though because it's useful as is
|
Rebase to fix the failing CI job. #2366 |
mergify bot
added a commit
to Agoric/agoric-sdk
that referenced
this pull request
Aug 12, 2024
closes: #9693 ## Description more linting for #9693, using endojs/endo#2369 Also adopts `harden-exports` for `.contract.js` modules, - #4770 ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations none ### Testing Considerations CI with expected errors ### Upgrade Considerations n/a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: Agoric/agoric-sdk#9726
Description
A new lint rule,
harden-exports, to support Agoric/agoric-sdk#9726Includes an autofixer
Security Considerations
Could enhance security
Scaling Considerations
n/a
Documentation Considerations
We don't yet document provided rules: https://endojs.github.io/endo/modules/_endo_eslint_plugin.html
I think that's okay for now. If that is requested I'd file it as a separate issue, out of scope of this one.
Testing Considerations
I temporarily enabled this in the recommended config and ran
lint-fixon the repo. All the changes looked correct. Howeverharden()isn't always available so I don't think we should enable it in any of Endo's shared configs.Compatibility Considerations
n/a
Upgrade Considerations
n/a