Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: change docker-compose to docker compose #110

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

frazarshad
Copy link
Contributor

@frazarshad frazarshad commented Aug 9, 2024

Closes: #111

Fixes some flakes in e2e testing.

  • Firstly used docker compose instead of docker-compose (which is not being recognized by github actions)
  • Secondly removed some unnecessary steps to give some space to the github runner, otherwise the job was failing due to space limit being reached

Copy link

cloudflare-workers-and-pages bot commented Aug 9, 2024

Deploying dapp-econ-gov with  Cloudflare Pages  Cloudflare Pages

Latest commit: 324729d
Status: ✅  Deploy successful!
Preview URL: https://fd00d9a0.dapp-econ-gov.pages.dev
Branch Preview URL: https://fraz-use-docker-compose-v2.dapp-econ-gov.pages.dev

View logs

Copy link

github-actions bot commented Aug 9, 2024

Cloudflare deployment logs are available here

@rabi-siddique
Copy link
Contributor

there were some errors related to space running out for the runner

Do we know the cause of this issue? Is there a chance it could occur in other dapps where we've implemented e2e tests? Should we consider applying this change across all our dapps?

@frazarshad
Copy link
Contributor Author

Do we know the cause of this issue? Is there a chance it could occur in other dapps where we've implemented e2e tests? Should we consider applying this change across all our dapps?

Dont really know the root cause. probably due to some increase in the size of our containers.

This probably can become an issue for our other dapps so i've created PRs for them too

Copy link
Contributor

@rabi-siddique rabi-siddique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this man. Do you think we should create an issue for documentation purposes? To help track the problem and provide clarity for anyone encountering it in the future.

@frazarshad
Copy link
Contributor Author

@rabi-siddique added the issue

@rabi-siddique
Copy link
Contributor

@rabi-siddique added the issue

LGTM. Let's merge this.

@frazarshad frazarshad merged commit ef19026 into main Aug 12, 2024
3 checks passed
@frazarshad frazarshad deleted the fraz/use-docker-compose-v2 branch August 12, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: tests are failing due to docker-compose command not being found
2 participants