refactor: move segment manifest cache to fetch module #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeqo
force-pushed
the
jeqo/refactor-segment-manifest-cache
branch
2 times, most recently
from
be5f6ff
to
3b8678f
Compare
jeqo
commented
Sep 11, 2024
There was a problem hiding this comment.
Expanding to make it compatible with RSMConfig defaults
There was a problem hiding this comment.
Cover all defaults config tests + new set default option
There was a problem hiding this comment.
Handled by CacheConfigTest already
| @@ -0,0 +1,123 @@ | |||
| /* | |||
| * Copyright 2023 Aiven Oy | |||
There was a problem hiding this comment.
not new, but moving+renaming SegmentManifestProvider
jeqo
changed the title
Moving the segment-manifest fetching to the fetch module helps to align with other caches and reuse configuration. Following work should help to align cache config for chunk caching.
jeqo
force-pushed
the
jeqo/refactor-segment-manifest-cache
branch
from
3b8678f
to
11d4afe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: There were some previous efforts on defining generic cache config. This follows up on that by making the SegmentManifest fetching reuse this definition. It also aligns with the SegmentIndexes fetching.
Moving the segment-manifest fetching to the fetch module helps to align with other caches and reuse configuration.
Following work should help to align cache config for chunk caching.