refactor: reuse cache config on chunk cache #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeqo
force-pushed
the
jeqo/refactor-segment-manifest-cache
branch
from
3b8678f
to
11d4afe
Compare
jeqo
force-pushed
the
jeqo/refactor-chunk-cache
branch
from
ee0fc66
to
0927872
Compare
Base automatically changed from
jeqo/refactor-segment-manifest-cache
to
main
September 13, 2024 13:30
Extend cache config with chunk cache configs (default and disk-based config) to reuse the configuration definitions.
jeqo
force-pushed
the
jeqo/refactor-chunk-cache
branch
from
0927872
to
21fac2c
Compare
jeqo
commented
Sep 13, 2024
| @@ -4,7 +4,6 @@ on: | |||
| push: | |||
| branches: [ 'main' ] | |||
| pull_request: | |||
| branches: [ 'main' ] | |||
There was a problem hiding this comment.
Adding this in a separate commit to allow other chained PRs to build fully instead of waiting for main to be the base branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend cache config with chunk cache configs (default and disk-based config) to reuse the configuration definitions.