-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remaining Gradio 3.23 issues #100
Comments
For me, I totally don't see any "send" buttons, just the "folder" one. 🙂 |
That's a bit odd though. It mostly works for me. Do you have the latest commits of both webui and this extension? Also it seems Firefox is having more touble than Chrome based browsers. |
Yes, both of them are the lastest. "main"/"master" branches. I'm using Edge. |
Can you hit F12 and see if there are any messages in the javascript console about image browser? There are currently many about other parts, those you can ignore at the moment. |
One other thing, I've noticed the gallery size seems to be a factor. Does changing it to the default 6 x 6 do anything? |
After pulling the latest commit, these issues still exist:
|
These Gradio issues really have me scratching my head. I don't mind bugs caused by it or changes I have to make, as long as I can test them. But this Gradio update seems to have left different issues with different people. For example the checkpoint list issue you describe is not happenening for me. Frustrating. Anyway, can you hit F12 and see if there are any messages in the javascript console about image browser? |
I'm adding this here instead of a new issue since it only came about after pulling the latest in both git repo's image_browser.js?1679937079.8286097:183 |
Hey, I'm having the same kind of issue. When I have this extension enabled, I get a loading symbol for everything basically. All my quick settings at the top and every setting in the settings tab. |
I just found a couple of issue's with some of webui's javascripts. If noone has done this yet, I'll put in PR. |
@Puddz |
Sure. It lead to a .js
|
Can someone pull my webui PR and check if it also improves some image browser issues? |
@AlUlkesh
A lot of warnings when loading the UI though ;
|
I also have what @forsurefr has in my console as well. Disabled deforum and looked and that was there. |
That's been there before the Gradio changes, shouldn't be an issue, For more details see #28. |
@forsurefr
Perhaps we can find another hint there. |
With the extension enabled, even the settings page was not loaded so I had to edit The only thing that is related to image browser is:
These are the image browser settings:
|
Which OS, web browser, python version are you using? |
So, I found out on my fresh SD install that I originally did to fix an issue with the preview images not loading on the main tab, that if the "https://github.com/AlUlkesh/stable-diffusion-webui-images-browser.git" extension is enabled, the Checkpoint dropdown at the top and the contents Settings tab will never load, the "spinning orange boxes" loading icons just stay. Disabling the extension, restarting the UI, and then reloading the browser tab will allow the settings to show up again. The tab reload doesn't help as long as the extension is enabled. However, I found out this issue affects desktop Firefox but not desktop Chrome. Mobile Chrome and Firefox also have the issue. Which is a shame, because I kind of need the extension to use SD from my phone, since I can't browse my desktop folders from it effectively. Windows 10 Pro and an Android phone, Image Browser extension is version a9032d4 (Mon Mar 27 14:14:06 2023) The status bar of the bottom of my UI: |
My setup is the same but using Brave on desktop. Have not tried Chrome or Firefox. |
I just tried Chrome, Firefox and Brave, but they all do not have this issue for me (Win 10). I suggest you try the PR I quoted above, I think that solves a lot of issues. |
You Rock! |
It looks like the "Send to" buttons are missing when using the image browser from a mobile device. |
@horribleCodes |
Hi, I fixed for my extension (VectorStudio) the sendtoControlnet today. here the code snippet for the function "image_browser_controlnet_send"
on initial load the click()-method have a race condition if not per design a glitch. the click on tab does create the DOM, which is done defered. So I add a timeout after click() and come back to the same routine try to handle it, now. replace "vectorstudio_" to imagebrowser of course. |
Honestly at this point nothing about the extension is doing anything on my tablet. I'm not getting any log messages at all, even with all logging enabled - it's working fine on my PC. |
@horribleCodes
This code is executed at the very beginning, before any ui is even created. If you don't even get that, that would probably mean, the script is not being loaded (correctly) by webui. But then that should be on your console. I'm a little lost here. |
Can anyone who still has issues please follow the new debug info guide: #130 and post your logs? |
Okay, even at log level 3 my tablet isn't triggering any log messages, even though it works fine on my PC. However, that was on Brave, and when I tried 2 different Chromium browsers, the images loaded. However, one refused to load the EXIF data, and both still aren't showing the "Send To"-buttons. Here's what I get when I loaded the first page and selected an image:
|
Can you all try the latest update please: #135 |
unsure if this is a bug or just a feature that's yet to be migrated from prior to 3.23, but i've found that
if these are indeed bugs, i will submit debug logs edit: nevermind...? ig i'm just on an outdated version... i installed image browser on a fresh install of the webui and everything works perfectly. now to... figure out how to get the webui to acknowledge the latest version |
The first issue is a webui issue. I actually have submitted a PR to fix that. But it's been waiting for weeks to get merged by now. Check the third point here: #107 You might want to install that manually and try it out. |
how would i do a manual install? am i supposed to git clone your repo into my webui directory? |
There are several ways to do it. The cleanest would probably be to create a local branch like this:
If you want to switch back to the master branch later, do:
|
thanks- 9060 was successfully able to fix the zoom issue. ig i just wait for it to be merged, now |
I was having the same problem, but thanks to someone else bringing it up, the issue was being caused by my Open Pose extension (for some reason) being stuck on an outdated version. Every time I tried to update it from the UI, it would just stay out of date. I had to delete it and reinstall it fresh to get it up to date, but once that was done, all of my problems in the image browser went away. |
so i did what you mentioned, switched back to the master branch, then ran |
I do not switch from any other branch to main or so, my experience is the bug is sporadic: sometimes i can open a small preview in details view (zoom view) and sometimes not. |
sure, i just mention that i switched from the master branch bc i previously was on pr9060 to fix the issue |
found something about the "Cant see zoomed image" bug: image only zoomed view when dev-tools on |
It's possible. I also have had another bug where the issue goes away if you make your browser window smaller, which would also be true in your case with devtools taking up a lot of the space. Have you tried the PR I mentioned above to see if the problem goes away? |
I don’t know if it’s related to this issue. The front-end performance of the image browser is particularly poor in the latest version of webui (of course, the front-end performance of the latest version of webui is not good). I know it’s related to Gradio. Almost every operation requires waiting for Gradio’s animation. In the image browser, I like to click and operate very quickly. Now I can’t use it smoothly. 不知道和这个issue有没有关系,image browser 在最新版本的 webui 中前端性能格外差(当然,最新版本 webui 的前端性能本来也不好),我知道和 gradio 有关系,几乎每个操作后都要等 gradio 的动画,在 image browser 中我喜欢很迅速地点击、操作,现在我不能很流畅地使用了。 |
@JoeyLearnsToCode So perhaps, you can check, how your system's status is, when those slowdowns happen? |
@AlUlkesh thank you for reply, my RAM capacity is 32GB, that should not be the reason in my case. |
@JoeyLearnsToCode |
@AlUlkesh wow, much better! |
@JoeyLearnsToCode Let's look at this issue here: #159 |
There currently are still several issues, where the new Gradio version causes weird interactions.
Most of these should be fixed, when the current PRs on the webui's side go through.
I think it would be a waste of time to hunt and fix something until then. Hope that goes faster than PRs did recently.
The text was updated successfully, but these errors were encountered: