Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete can delete wrong image #159

Closed
AlUlkesh opened this issue May 6, 2023 · 5 comments
Closed

Delete can delete wrong image #159

AlUlkesh opened this issue May 6, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@AlUlkesh
Copy link
Owner

AlUlkesh commented May 6, 2023

@JoeyLearnsToCode:

But now I find another problem, the "Generation Info" part update with 1s delay after switching image(which is realtime and fast).
Within that second of delay, delete button seems to delete the previous image(before switch), not the new one(after).

I already fixed this bug twice. I wonder what changed to make it reappear 😧

@JoeyLearnsToCode
Copy link

I blame it on gradio instead of image browser.

@AlUlkesh AlUlkesh added the bug Something isn't working label May 7, 2023
@AlUlkesh
Copy link
Owner Author

AlUlkesh commented May 7, 2023

Yeah, I'm actually impressed the original author was able to pull this off, despite the massive Gradio limitations.

This commit should fix this.

@AlUlkesh AlUlkesh closed this as completed May 7, 2023
@bryanray
Copy link

bryanray commented May 7, 2023

please make the delete option using "recycle bin" as default :)

@AlUlkesh
Copy link
Owner Author

AlUlkesh commented May 8, 2023

I have no idea, why this wasn't the default option already... I changed it, thanks.

@bryanray
Copy link

bryanray commented May 8, 2023

thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants