add to ship definitions get_blocks v1 (for fetch_finality_data) #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
May 1, 2024
heifner
reviewed
Jun 6, 2024
| uint32_t active_finalizer_policy_generation = {}; | ||
| eosio::checksum256 action_mroot = {}; | ||
| eosio::checksum256 base_digest = {}; | ||
| }; |
There was a problem hiding this comment.
Shouldn't this include proposed_finalizer_policy
There was a problem hiding this comment.
I built this from
https://github.com/AntelopeIO/spring/blob/8f65101b071768e8f213cd62e1a580f55aed882b/libraries/state_history/abi.cpp#L576-L581
which is lacking proposed_finalizer_policy. It does seem like this is an oversight in spring's abi.cpp
There was a problem hiding this comment.
Does look like that was missed.
https://github.com/AntelopeIO/spring/blob/3133bc1713a992139494eb3250c94a48336566a1/plugins/state_history_plugin/state_history_plugin.cpp#L290-L290
packs finality_data_t which contains proposed_finalizer_policy
|
updated and ready for re-review |
linh2931
approved these changes
Jun 12, 2024
heifner
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Message was added in AntelopeIO/leap#2349 and tweaked in AntelopeIO/leap#2381