Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add to ship definitions get_blocks v1 (for fetch_finality_data) #28

Merged
merged 4 commits into from
Jun 12, 2024
Merged

add to ship definitions get_blocks v1 (for fetch_finality_data) #28

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1633362
add get_blocks v1 (for fetch_finality_data)
spoonincode May 1, 2024
24b7345
add finality_data too
spoonincode Jun 4, 2024
4aa297f
clean up my sloppy whitespace
spoonincode Jun 6, 2024
384c59b
fill out finality_data further
spoonincode Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions include/eosio/ship_protocol.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,6 +808,17 @@ namespace eosio { namespace ship_protocol {

using resource_limits_config = std::variant<resource_limits_config_v0>;

struct finality_data {
uint32_t major_version = {};
uint32_t minor_version = {};
uint32_t active_finalizer_policy_generation = {};
eosio::checksum256 action_mroot = {};
eosio::checksum256 base_digest = {};
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this include proposed_finalizer_policy

https://github.com/AntelopeIO/spring/blob/e1696d2dbbcd99879e303473572d5607be86cad5/libraries/chain/include/eosio/chain/block_state.hpp#L61-L61

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built this from
https://github.com/AntelopeIO/spring/blob/8f65101b071768e8f213cd62e1a580f55aed882b/libraries/state_history/abi.cpp#L576-L581
which is lacking proposed_finalizer_policy. It does seem like this is an oversight in spring's abi.cpp

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does look like that was missed.
https://github.com/AntelopeIO/spring/blob/3133bc1713a992139494eb3250c94a48336566a1/plugins/state_history_plugin/state_history_plugin.cpp#L290-L290
packs finality_data_t which contains proposed_finalizer_policy


EOSIO_REFLECT(finality_data, major_version, minor_version, active_finalizer_policy_generation,
action_mroot, base_digest)

}} // namespace eosio::ship_protocol

namespace eosio {
Expand Down