-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement nats avro serdes #5195
Conversation
|
||
T getPayload(); | ||
|
||
void ack(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add Nack() and Term() also.
|
||
public static final Integer NATS_PORT = 4222; | ||
|
||
public static final Integer NATS_MGMT_PORT = 8222; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8222 is considered to be a monitoring port, can we rename this field to NATS_MNTR_PORT ?
|
||
NatsConsumerRecord<T> receive() throws JetStreamApiException, IOException; | ||
|
||
NatsConsumerRecord<T> receive(Duration timeout) throws JetStreamApiException, IOException; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rename it to fetch ?
NATS does not uses receive but pull or fetch.
Difference between pull and fetch is, fetch return the list of messages while pull keeps the message in in memory iterator and users then have to next() to read message from iterator.
|
||
public interface NatsProducer<T> extends AutoCloseable { | ||
|
||
void send(T message) throws ApicurioNatsException; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's rename it to publish and add publishAsync too ?
Good comments, I'm going to create an issue so we can track them better. |
@sourabhaggrawal I have created the following GH issue to track your comments: #5215. Would you be open to contribute a PR to address them? |
Thank you @carlesarnal, I have submitted PR for changes #5222 |
No description provided.