-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements on Nats Serdes #5222
base: main
Are you sure you want to change the base?
Conversation
Thank you for creating a pull request! Pinging @carlesarnal to respond or triage. |
@souravagrawal I'm missing test cases for the newly added methods. You have the exiting one as an example, could you please add tests for the other methods as well? |
Hi @carlesarnal Yes I have added them now |
Hi @carlesarnal I do not understand why test is failing, there is no test with expected value as false in AvroNatsSerdeIT. |
@sourabhaggrawal the tests results are apparently not consistent. Can you please take a look? |
Fixes #5215