Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2e tests #116

Merged
merged 45 commits into from
Sep 13, 2023
Merged

E2e tests #116

merged 45 commits into from
Sep 13, 2023

Conversation

federiva
Copy link
Contributor

@federiva federiva commented Jul 24, 2023 •
edited
Loading

Have you read the Contributing Guidelines?

Closes #104
Closes #68

What this PR is about

  • Only saving screenshots when running them from the cli cypress run... as commented in this issue
  • Snapshot, visual tests using cypress-plugin-snapshots
  • Added yarn scripts for every example app
  • Added a wrapper script to run them all at once
  • Added R scripts to run the Shiny apps

Added new issue

  • Remove TODOs from cypress tests - We need to find on-render'ish events for the SVG paths to use them when writing the snapshot tests. Right now we are using explicit wait statements which is not ideal as rendering it is not deterministic/depending on many factors affecting the time of render

How to test

  1. Read the README on adding new tests
  2. Ensure that you have your yarn dependencies updated (go to tests/ and run yarn install)
  3. Go to the tests/ folder in the terminal and run run_cypress_tests -> Ensure that all of the tests have passed
  4. Optional. You can inspect the package.json file and run some tests individually: for example via yarn e2e-areaChart

@federiva
fix: removing commented code
0300845
@federiva
fix: Updating script running tests
fe0bd45
@federiva
chore: Adding cypress/videos
faddc6b
@federiva
fix: Updating screenshots cypress-io/cypress#3324 (comment)
7d072cb
@federiva
fix: Specifying port
21d9d2f
@federiva
feat: Adding R script for barchart example
45aa1d2
@federiva
feat: Adding tests and scripts for barchart
3cc0f08
@federiva
feat: Adding snapshot tests for areachart
9e8e195
@federiva
chore: empty line
fbf3caf
@federiva
feat: Adding circularVisualEncoding test
21295b9
@federiva
feat: Adding script to create testfiles
d7b3878
@federiva
feat: adding ideogram
da75055
@federiva
feat: Adding pointplot
a929827
@federiva
feat: adding multitrack
9320bf0
@federiva
tests: Adding tests for lineChart
66d6a41
@federiva
tests: Adding tests for ruleMarks
88ff42f
@federiva
feat: Adding template for code generating scripts
ea31763
@federiva
tests: Adding sarsCov
8b84fc3
@federiva
tests: Adding tests
04d2f9b
@federiva
feat: adding script to run all of the tests
6fe70f6
@federiva
fix: adding paths
e58804a
vedhav
vedhav reviewed Jul 28, 2023
View reviewed changes
tests/package.json Outdated Show resolved Hide resolved
vedhav
vedhav reviewed Jul 28, 2023
View reviewed changes
Copy link
Member

@vedhav vedhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The snapshots failed for me as you mentioned earlier, It Looks like we need to specify some tolerance.

Screenshot 2023-07-28 at 10 50 12 PM

@federiva federiva marked this pull request as ready for review July 31, 2023 03:50
@federiva federiva requested a review from vedhav July 31, 2023 03:54
@federiva federiva mentioned this pull request Aug 1, 2023
Merged
federiva and others added 2 commits August 23, 2023 16:37
@federiva @vedhav
feat: Simplifying script for running tests (#120)
9f3d24d 
* feat: Simplifying script for running tests

* chore: Adding optparse

* Update tests/run_cypress_tests.sh

Co-authored-by: Vedha Viyash <[email protected]>

* fix: Adding folders

* style: lintr

* fix: Adding run_example_app helper script

* fix: Moving e2e folder

---------

Co-authored-by: Vedha Viyash <[email protected]>
@federiva
Merge branch 'dev' of github.com:Appsilon/shiny.gosling into e2e-tests
4106f44
anirbanshaw24
anirbanshaw24 approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@anirbanshaw24 anirbanshaw24 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Thanks for getting this to work. 🎉
LGTM. Approved ✅

@anirbanshaw24 anirbanshaw24 merged commit 73b96dd into dev Sep 13, 2023
5 checks passed
@anirbanshaw24 anirbanshaw24 deleted the e2e-tests branch September 13, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anirbanshaw24 anirbanshaw24 anirbanshaw24 approved these changes

@vedhav vedhav Awaiting requested review from vedhav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@federiva @anirbanshaw24 @vedhav