Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Simplifying script for running tests #120

Merged
merged 8 commits into from
Aug 23, 2023

Conversation

federiva
Copy link
Contributor

@federiva federiva commented Aug 1, 2023

Simplifying way of running tests as discussed in the PR #116

See README for reference and usage

@federiva federiva requested a review from vedhav August 1, 2023 19:01
@federiva federiva mentioned this pull request Aug 1, 2023
@federiva federiva marked this pull request as ready for review August 3, 2023 13:23
Copy link
Member

@vedhav vedhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work simplifying the tests. The readme docs are clear and easy to follow.
I just added a suggestion to change the run test shell script as it did not work on my machine.
Please merge it after checking that.

tests/run_cypress_tests.sh Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (e2e-tests@52ae644). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##             e2e-tests    #120   +/-   ##
===========================================
  Coverage             ?   9.59%           
===========================================
  Files                ?      13           
  Lines                ?     198           
  Branches             ?       0           
===========================================
  Hits                 ?      19           
  Misses               ?     179           
  Partials             ?       0           

@federiva federiva merged commit 9f3d24d into e2e-tests Aug 23, 2023
5 checks passed
@anirbanshaw24 anirbanshaw24 deleted the e2e-tests-alternative-run branch September 28, 2023 07:09
@anirbanshaw24 anirbanshaw24 restored the e2e-tests-alternative-run branch September 28, 2023 07:09
@anirbanshaw24 anirbanshaw24 deleted the e2e-tests-alternative-run branch September 28, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants