-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools: ros2: Add geopose test #25642
Conversation
Is it just the new test that is causing the hang, or all of them? We already have tests covering best effort and reliable streams, so don't think that is the issue?
Ah - just saw that tacked to the end. We could add a timeout on each test, otherwise it will just wait for the agent service. Or better, add a condition that the agent be present (and a timeout). |
Yea, a timeout would be great. Even with proper directory layout, the geopose test still fails and all the others pass. Locally, running the launch files, I get geopose data. Do you have any idea why that channel is not working when run through |
87c8d75
to
bab6179
Compare
Any recommendations on how to implement the best approach? I'd really like to get better test coverage of this interface in CI. |
3321f12
to
c7e6bbe
Compare
* Add missing deps * Reduce some duplication Signed-off-by: Ryan Friedman <[email protected]>
Signed-off-by: Ryan Friedman <[email protected]>
c7e6bbe
to
14e2eda
Compare
I got the test to pass locally, there were a few typos. Instead of just checking we got a message, this also checks the position is correct. |
Purpose
How to test
Known issue
The heading reported by ROS2 never matches CMAC's configured heading. It's not clear whether the heading configured in
locations.txt
is magnetic or true north, but it's more off than that.