Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copter: Give better error in opendroneid build when DID_ENABLE=0. #26870

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

shipp02
Copy link
Contributor

@shipp02 shipp02 commented Apr 23, 2024

Based on my report on discord:

Problem arises when:

  • ArduPilot compiled with --enable-opendroneid
  • DID_ENABLE set to 0
  • init and update functions do not do anything but pre_arm_checks still fail.

Should pre_arm_checks also be skipped or there should be a different error message like DID_ENABLE is not allowed to be 0 when compiled with --enable-opendroneid.

Currently one of the pre_arm_checks will fail but there's no indiciation of what exactly the problem is. A better error message or disabling pre arm checks might save time for users.

This PR adds a better error message to report that DID_ENABLE is not allowed to be 0 when compiled with --enable-opendroneid.

@shipp02 shipp02 marked this pull request as ready for review April 23, 2024 01:31
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autotests need to pass; looks like the new check in here is causing them to fail, hinting to me that it is possible to compile opendroneid in yet have pre-arm-checks pass even with the option off.

@peterbarker
Copy link
Contributor

@shipp02 I've squashed commits together and fixed a whitespace change problem.

Can you state exactly what the prearm-failure you were getting before this PR?

@tridge tridge merged commit dcc526e into ArduPilot:master Sep 16, 2024
95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants