Stop iniswapping from modifying the char.ini file #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emove comments such as credits, charmaker notes, etc.)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…me is reloaded Prevent reload theme from resetting your emote to the first one
oldmud0
reviewed
Apr 11, 2022
| @@ -1450,7 +1450,7 @@ void Courtroom::set_pos_dropdown(QStringList pos_dropdowns) | |||
| set_side(current_side); | |||
| } | |||
|
|
|||
| void Courtroom::update_character(int p_cid) | |||
| void Courtroom::update_character(int p_cid, QString char_name, bool reset_emote) | |||
There was a problem hiding this comment.
Why does cid matter if we know that char_name is going to override it? I think this CID thing is really a vestigial part of the protocol at this point and we should seclude it to some packet handler.
Likewise, instead of adding reset_emote we can extract a method for that.
stonedDiscord
previously approved these changes
Jun 6, 2022
|
what happened with |
oldmud0
previously requested changes
Jul 17, 2022
…Online/AO2-Client into fix-iniswap-file-io
…ne/AO2-Client into fix-iniswap-file-io
TrickyLeifa
previously requested changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop iniswapping from modifying the char.ini (which can potentially remove comments such as credits, charmaker notes, etc.)
It also lead to really annoying behavior where if you swapped out from that character, when you swap back you'd be put into the iniswap instead of the default state, which could even be outside that character's iniswap list.
Closes #737