-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop iniswapping from modifying the char.ini file #712
Merged
Merged
Changes from 6 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
ef6ab97
Stop iniswapping from modifying the char.ini (which can potentially r…
Crystalwarrior cdaad99
Fix iniswaps.ini and soundlist.ini not using vpath
Crystalwarrior 15ac56e
Deprecate get_char_name, making "name=" part in the char.ini no longe…
Crystalwarrior 13a9e8a
Fix iniswap and emote dropdowns not getting properly updated when the…
Crystalwarrior 2efd040
last commit but actually
Crystalwarrior 59da682
Merge branch 'master' into fix-iniswap-file-io
stonedDiscord c9eddd4
Merge branch 'master' into fix-iniswap-file-io
stonedDiscord d5987b3
fallback soundlist.ini
stonedDiscord 3a77040
Merge branch 'master' into iniswap-soundlist-vpath
stonedDiscord 9001f52
Merge branch 'master' into fix-iniswap-file-io
stonedDiscord a4a1156
Merge branch 'master' into iniswap-soundlist-vpath
Crystalwarrior 631324d
Implement Longbyte's suggestions
Crystalwarrior b1ef418
Merge branch 'iniswap-soundlist-vpath' of https://github.com/Attorney…
Crystalwarrior 672fa91
Merge branch 'fix-iniswap-file-io' of https://github.com/AttorneyOnli…
Crystalwarrior 9c252d2
Deprecate get_char_name properly
Crystalwarrior 5387960
Revert a weird "vpath" iniswaps.ini thing that doesn't belong in this PR
Crystalwarrior 29e15fe
fix typo in comment
oldmud0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does cid matter if we know that char_name is going to override it? I think this CID thing is really a vestigial part of the protocol at this point and we should seclude it to some packet handler.
Likewise, instead of adding reset_emote we can extract a method for that.