-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove user_meta related sniffs #614
Comments
Loosely related to #600. The difference between #600 and these changes, is that these are not breaking changes as no sniffs are removed, only error codes (and groups). This means that this change might make some inline ignore annotations redundant and possibly make some values in custom properties in rulesets redundant, but other than that, it will not break rulesets and it will not break runs. In other words, these changes are "allowed" to go into a next minor and don't need to wait for the next major (though a choice can be made to let this wait for the next major anyway). |
I have prepared the commits for this. @rebeccahum Let me know if you want me to pull these changes now or when we're preparing for v3.0. |
@jrfnl Please pull the changes now. Thank you! |
User meta is easily accessible on VIP Go, no reason to have the user_meta grouping in the RestrictedFunctions sniff:
VIP-Coding-Standards/WordPressVIPMinimum/Sniffs/Functions/RestrictedFunctionsSniff.php
Lines 132 to 141 in 6d3f526
We silence it anyways on the WordPress-VIP-Go ruleset:
VIP-Coding-Standards/WordPress-VIP-Go/ruleset.xml
Lines 281 to 290 in 6d3f526
The same could be said for the RestrictedVariables sniff:
VIP-Coding-Standards/WordPressVIPMinimum/Sniffs/Variables/RestrictedVariablesSniff.php
Lines 41 to 47 in 6d3f526
Silenced on the same ruleset:
VIP-Coding-Standards/WordPress-VIP-Go/ruleset.xml
Lines 293 to 295 in 6d3f526
The text was updated successfully, but these errors were encountered: