Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get_super_admin grouping from RestrictedFunctions #616

Closed
rebeccahum opened this issue Jan 11, 2021 · 1 comment · Fixed by #647
Closed

Remove get_super_admin grouping from RestrictedFunctions #616

rebeccahum opened this issue Jan 11, 2021 · 1 comment · Fixed by #647
Milestone

Comments

@rebeccahum
Copy link
Contributor

No need to flag for super admin on VIP Go:

'get_super_admins' => [
'type' => 'error',
'message' => '`%s` is prohibited on the WordPress.com VIP platform.',
'functions' => [
'get_super_admins',
],
],

Silenced here anyways:

<rule ref="WordPressVIPMinimum.Functions.RestrictedFunctions.get_super_admins_get_super_admins">
<severity>0</severity>
</rule>

@jrfnl
Copy link
Collaborator

jrfnl commented Mar 2, 2021

Same as for #614:

Loosely related to #600.

The difference between #600 and these changes, is that these are not breaking changes as no sniffs are removed, only error codes (and groups).

This means that this change might make some inline ignore annotations redundant and possibly make some values in custom properties in rulesets redundant, but other than that, it will not break rulesets and it will not break runs.

In other words, these changes are "allowed" to go into a next minor and don't need to wait for the next major (though a choice can be made to let this wait for the next major anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants