Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the icons don't allow for props to be passed to the main SVG component.
The problem is that this prevents the mobile Gutenberg editor from passing in the correct fill prop for the icon.
On the mobile inserted.
Before:
After:
To tests
I build a new version of the layout-grid plugin.
using
yarn plugin layout-grid
and then
yarn bundle
And then I installed the plugin on my site.
And tried to find if the icons have changed anywhere with undesirable outcomes.
See:
To test it on mobile I followed the instructions in wordpress-mobile/gutenberg-mobile#2582
and then patched the icon file. Which fixed how the icons appeared.