-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/experimental block grid block #2582
base: trunk
Are you sure you want to change the base?
Conversation
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
277f44a
to
59027d4
Compare
59027d4
to
b4b348d
Compare
b4b348d
to
968e1c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on iOS and Android and all works as expected! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested on iOS and Android. Worked as expected.
src/index.js
Outdated
// I am not sure this is the right way to do this. | ||
// But if I do an import instead we end up with an error. | ||
require( './block-experiments-setup' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe relying upon require
may be necessary as Metro does not support dynamic import
s currently.
968e1c6
to
1a8bb9a
Compare
Block Experiments PR: Automattic/block-experiments#136 (Updates to the layout grid blocks edit)
Here we are adding the
block-experiments
repo that includes the layout-grid block. In order to add support for that block in the gutenberg mobile editor.This PR just add the basic read only block and doesn't include support for all the different block attributes that the layout block current supports.
This PR add the following:
How this PR has been tested.
It has been tested on the demo app only.
To test:
Add the new repo:
Start the demo app
Now you should be able to add the layout grid block to the demo app.
See
After it is inserted it looks like this.
PR submission checklist: