Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/experimental block grid block #2582

Open
wants to merge 8 commits into
base: trunk
Choose a base branch
from

Conversation

enejb
Copy link
Contributor

@enejb enejb commented Aug 28, 2020

Block Experiments PR: Automattic/block-experiments#136 (Updates to the layout grid blocks edit)

Here we are adding the block-experiments repo that includes the layout-grid block. In order to add support for that block in the gutenberg mobile editor.

This PR just add the basic read only block and doesn't include support for all the different block attributes that the layout block current supports.

This PR add the following:

  1. The block-experiments repo as a submodule.
  2. The layout-grid block as a block so that it can be added to the block editor.

How this PR has been tested.
It has been tested on the demo app only.

To test:
Add the new repo:

git submodule init
git submodule update

Start the demo app

npm run start:reset
npm run core ios

Now you should be able to add the layout grid block to the demo app.
See

After it is inserted it looks like this.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 28, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@enejb enejb mentioned this pull request Mar 31, 2021
2 tasks
@enejb enejb force-pushed the add/experimental-block-grid-block branch from b4b348d to 968e1c6 Compare April 13, 2021 17:34
@enejb enejb requested a review from ceyhun April 13, 2021 17:36
Copy link
Contributor

@AmandaRiu AmandaRiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on iOS and Android and all works as expected! 👍 :shipit:

Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested on iOS and Android. Worked as expected.

src/index.js Outdated
Comment on lines 27 to 29
// I am not sure this is the right way to do this.
// But if I do an import instead we end up with an error.
require( './block-experiments-setup' );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe relying upon require may be necessary as Metro does not support dynamic imports currently.

@enejb enejb force-pushed the add/experimental-block-grid-block branch from 968e1c6 to 1a8bb9a Compare April 23, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants