Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing Block: update messaging in Jetpack Dashboard > Settings > Sharing to mention new block #34325

Closed
Tracked by #19694
jeherve opened this issue Nov 28, 2023 · 4 comments · Fixed by #34619
Closed
Tracked by #19694

Sharing Block: update messaging in Jetpack Dashboard > Settings > Sharing to mention new block #34325

jeherve opened this issue Nov 28, 2023 · 4 comments · Fixed by #34619
Assignees
@jeherve @andrii-lysenko
Labels
Admin Page React-powered dashboard under the Jetpack menu [Block] Sharing Buttons Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Sharing Post sharing, sharing buttons [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Focus] FSE Issues related to the site editor / Full Site Editing / FSE feature in Gutenberg [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@jeherve
Copy link
Member

jeherve commented Nov 28, 2023 •
edited
Loading

When a site owner uses a block-based theme, they should not be offered an option to turn on the sharing module. Instead, we should suggest they go to the site editor and add the new sharing block to their site templates.

image

Epic: #19694
@jeherve jeherve mentioned this issue Nov 28, 2023
Closed
5 tasks
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Sharing Post sharing, sharing buttons Admin Page React-powered dashboard under the Jetpack menu [Pri] Normal [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Focus] FSE Issues related to the site editor / Full Site Editing / FSE feature in Gutenberg [Block] Sharing Buttons [Status] Needs Design labels Nov 28, 2023
@keoshi
Copy link
Contributor

keoshi commented Nov 28, 2023

Agreed! I think the UI should be dynamic here, showing only the relevant information depending on the type of theme is active at a given time.

Legacy theme

image

Block theme

image

Changes:

  • Removes toggle since it's not needed.
  • Gets rid of the external icon because the user stays in the site.

The settings UI starts to fall apart a little bit with all the dividers, but let's worry about that later.

@keoshi keoshi mentioned this issue Nov 29, 2023
Closed
@jeherve
Copy link
Member Author

jeherve commented Nov 30, 2023

This sounds good to me for a start. Later on, maybe we could explore automatically adding the buttons to single posts templates with a toggle there (or in wp-admin sharing settings, or in both places?). We're having a conversation about that here:
pdDOJh-2JP-p2#comment-2093

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 30, 2023 •
edited
Loading

Support References

This comment is automatically generated. Please do not edit it.

  • pdDOJh-2JP-p2#comment-2093

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Nov 30, 2023
jeherve added a commit that referenced this issue Dec 13, 2023
@jeherve
Update the interface to account for the sharing block
202df94 
Fixes #34325

See the designs in #34325 (comment) for more explanation.
@jeherve jeherve mentioned this issue Dec 13, 2023
Merged
3 tasks
@andrii-lysenko andrii-lysenko mentioned this issue Dec 18, 2023
Closed
andrii-lysenko pushed a commit that referenced this issue Dec 22, 2023
@jeherve
Jetpack Dashboard: update sharing settings to account for upcoming sh…
6abdfef 
…aring block (#34619)

* Dashboard: Get sharing block availability for use in dashboard

This will allow us to conditionally display different links whether the upcoming sharing block is available or not.

Down the road, we can remove those settings when the sharing block will be available for everyone.

* Make theme and sharing block info available to Sharing component

* Update the interface to account for the sharing block

Fixes #34325

See the designs in #34325 (comment) for more explanation.

* Add changelog

* Link to a different support doc when you use the sharing block

* Always display the legacy module toggle, but suggest the block

See discussion in #34619 (comment)

* update wording
matticbot pushed a commit to Automattic/jetpack-storybook that referenced this issue Dec 22, 2023
@andrii-lysenko @matticbot
Jetpack Dashboard: update sharing settings to account for upcoming sh…
f549adb 
…aring block (#34619)

* Dashboard: Get sharing block availability for use in dashboard

This will allow us to conditionally display different links whether the upcoming sharing block is available or not.

Down the road, we can remove those settings when the sharing block will be available for everyone.

* Make theme and sharing block info available to Sharing component

* Update the interface to account for the sharing block

Fixes #34325

See the designs in Automattic/jetpack#34325 (comment) for more explanation.

* Add changelog

* Link to a different support doc when you use the sharing block

* Always display the legacy module toggle, but suggest the block

See discussion in Automattic/jetpack#34619 (comment)

* update wording

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/7302442324
matticbot pushed a commit to Automattic/jetpack-production that referenced this issue Dec 22, 2023
@andrii-lysenko @matticbot
Jetpack Dashboard: update sharing settings to account for upcoming sh…
51ffb41 
…aring block (#34619)

* Dashboard: Get sharing block availability for use in dashboard

This will allow us to conditionally display different links whether the upcoming sharing block is available or not.

Down the road, we can remove those settings when the sharing block will be available for everyone.

* Make theme and sharing block info available to Sharing component

* Update the interface to account for the sharing block

Fixes #34325

See the designs in Automattic/jetpack#34325 (comment) for more explanation.

* Add changelog

* Link to a different support doc when you use the sharing block

* Always display the legacy module toggle, but suggest the block

See discussion in Automattic/jetpack#34619 (comment)

* update wording

Committed via a GitHub action: https://github.com/Automattic/jetpack/actions/runs/7302442324
@simison
Copy link
Member

simison commented Jan 3, 2024

Instead, we should suggest they go to the site editor and add the new sharing block to their site templates.

I think the toggle was still helpful; site editor and fiddling with templates feels a bit more advanced.

Can we inject the block into post templates with the toggle turned on, instead of removing this as "legacy"? Block Hooks API I think is the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeherve jeherve

@andrii-lysenko andrii-lysenko

Labels
Admin Page React-powered dashboard under the Jetpack menu [Block] Sharing Buttons Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Sharing Post sharing, sharing buttons [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Focus] FSE Issues related to the site editor / Full Site Editing / FSE feature in Gutenberg [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Jetpack Dashboard: update sharing settings to account for upcoming sharing block Automattic/jetpack
4 participants
@simison @keoshi @jeherve @andrii-lysenko