Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing Block: switch jetpack_sharing_enabled to false, when block added to the page #34575

Closed
Tracked by #19694
andrii-lysenko opened this issue Dec 11, 2023 · 1 comment
Assignees
Labels
[Block] Sharing Buttons [Feature] Earn Blocks A collection of blocks designed as monetization tools that empower creators to generate income. [Feature] Sharing Post sharing, sharing buttons [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack

Comments

@andrii-lysenko
Copy link
Contributor

andrii-lysenko commented Dec 11, 2023

Currently, when adding a block to the page with jetpack_sharing_enabled user would need manually disable original behavior, to avoid having 2 sets of Sharing Buttons on the page.

To avoid this, a simple solution would be to simply disable original sharing buttons whenever the block is added. As we are still figuring out a way on how we would want the block positioned versus the original behavior, I think this change would make beta testing more convenient


Epic: #19694

@andrii-lysenko andrii-lysenko added [Feature] Sharing Post sharing, sharing buttons [Block] Sharing Buttons [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Feature] Earn Blocks A collection of blocks designed as monetization tools that empower creators to generate income. labels Dec 11, 2023
@andrii-lysenko
Copy link
Contributor Author

As per several discussions, it seems that we won't proceed with this simple solution. We are more likely to come up with a permanent solution of replacing old feature with the new block as a part of #34117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Sharing Buttons [Feature] Earn Blocks A collection of blocks designed as monetization tools that empower creators to generate income. [Feature] Sharing Post sharing, sharing buttons [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack
Projects
None yet
Development

No branches or pull requests

1 participant