-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharing block: ensure compatibility with global settings set in module #34117
Comments
While working on #34115 (hook new block buttons to Sharing_Service) we basically has copied the logic needed inside the block, having it entirely separated from the Sharing Service. We would still need to see, what would be the less confusing way to go, either entirely replace current logic (including central buttons controls in calypso), or make these work together. I suggest we hold off this task until we get some feedback from Call For Testing. |
#35542 brings us in this direction, but doesn't have any UI yet. We'll need to work on one, that will set the |
I think the easiest way would be if we could add UI to wp.com side on Following up #35542 we could read these settings (could we?) and fill with buttons and styles from old module. Also, on In terms of tasks I imagine it something like:
cc @keoshi |
If we do, we would definitely need to add the same UI to |
I created Automattic/wp-calypso#88294 to start with some improvements, and we're also discussing other options in https://github.com/Automattic/dotcom-forge/issues/5915 |
Ensure compatibility with sharing settings that may have been created via the old module.
Compatibility may mean separating the settings entirely so the new block is only managed via the block / site editor, but that needs to be made clear in settings UI.
This issue may be broken down into multiple issues if necessary.
Epic: #19694
The text was updated successfully, but these errors were encountered: