Update `@wordpress/eslint-plugin` #39305

anomiex · 2024-09-09T19:51:31Z

Proposed changes:

This brings two new rules that needed fixing:

@wordpress/i18n-no-flanking-whitespace complains about leading or trailing whitespace in JS i18n messages. Fix depends on context:
- Sometimes it makes no difference, the browser (or React) strips it out. Removed these.
- Sometimes it does, or it's unclear. In these cases I added it back outside the i18n call.
@wordpress/i18n-hyphenated-range wants en-dashes (or em-dashes) for numeric ranges. Switched them to en-dashes.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Places where these messages are used still looks right?

This brings two new rules that needed fixing: * `@wordpress/i18n-no-flanking-whitespace` complains about leading or trailing whitespace in JS i18n messages. Fix depends on context: * Sometimes it makes no difference, the browser (or React) strips it out. Removed these. * Sometimes it does, or it's unclear. In these cases I added it back outside the i18n call. * `@wordpress/i18n-hyphenated-range` wants en-dashes (or em-dashes) for numeric ranges. Switched them to en-dashes.

github-actions · 2024-09-09T19:52:42Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly. The next release is scheduled for October 1, 2024 (scheduled code freeze on September 30, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Protect plugin:

Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Super Cache plugin:

Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Migration plugin:

Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions · 2024-09-09T19:52:58Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/wordpress-eslint-plugin branch.
- For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/wordpress-eslint-plugin

bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/wordpress-eslint-plugin

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

zinigor

I have some questions about preserving spaces here, maybe we should test these to make sure.

zinigor · 2024-09-10T08:53:52Z

projects/packages/search/src/dashboard/components/upsell-nudge/index.jsx

 					'jetpack-search-pkg'
 				) }
-			</span>
+			</span>{ ' ' }


Should we put the space inside the span element to preserve the original behavior?

🤷 No idea. In practice CSS currently sets display: block on these spans so the whitespace gets ignored either way.

Before:

After:

zinigor · 2024-09-10T08:58:30Z

projects/plugins/protect/src/js/components/firewall-footer/index.jsx

@@ -70,7 +70,7 @@ const ShareDebugData = () => {

 	return (
 		<div className={ styles[ 'share-data-section' ] }>
-			<Title mb={ 2 }>{ __( ' Share detailed data with Jetpack', 'jetpack-protect' ) }</Title>
+			<Title mb={ 2 }>{ __( 'Share detailed data with Jetpack', 'jetpack-protect' ) }</Title>


Have you been able to figure out why there was a space here in the first place? Maybe we should preserve this one too?

It seems to go back to 021eb6a, beyond that I have no idea.

It made no difference to the rendering when I tried it. HTML ignores whitespace at the start of block elements like the <h2> generated here.

Before:

After:

zinigor · 2024-09-10T08:59:21Z

projects/plugins/protect/src/js/components/scan-footer/index.jsx

@@ -33,7 +33,7 @@ const ProductPromotion = () => {
 				<Title>{ __( 'Get access to our Cloud', 'jetpack-protect' ) }</Title>
 				<Text mb={ 3 }>
 					{ __(
-						'With your Protect upgrade, you have free access to scan your site on our Cloud, so you can be aware and fix your threats even if your site goes down. ',
+						'With your Protect upgrade, you have free access to scan your site on our Cloud, so you can be aware and fix your threats even if your site goes down.',


I'm afraid we'll have to preserve this too for inline elements.

What inline elements? The following element is a block-formatted button.

…int-plugin

zinigor

Thank you for doing the legwork and actually testing the changes!

anomiex requested a review from a team September 9, 2024 19:51

anomiex added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Janitorial [Pri] Normal labels Sep 9, 2024

anomiex self-assigned this Sep 9, 2024

zinigor reviewed Sep 10, 2024

View reviewed changes

Merge remote-tracking branch 'origin/trunk' into update/wordpress-esl…

b4d5e44

…int-plugin

zinigor approved these changes Sep 11, 2024

View reviewed changes

anomiex merged commit 3a06084 into trunk Sep 11, 2024
73 checks passed

anomiex deleted the update/wordpress-eslint-plugin branch September 11, 2024 16:19

github-actions bot removed the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label Sep 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update `@wordpress/eslint-plugin` #39305

Update `@wordpress/eslint-plugin` #39305

anomiex commented Sep 9, 2024

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading

zinigor left a comment

zinigor Sep 10, 2024

anomiex Sep 10, 2024

anomiex Sep 10, 2024

zinigor Sep 10, 2024

anomiex Sep 10, 2024

zinigor Sep 10, 2024

anomiex Sep 10, 2024

zinigor left a comment

Update @wordpress/eslint-plugin #39305

Update @wordpress/eslint-plugin #39305

Conversation

anomiex commented Sep 9, 2024

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Sep 9, 2024 • edited Loading

github-actions bot commented Sep 9, 2024 • edited Loading

zinigor left a comment

Choose a reason for hiding this comment

zinigor Sep 10, 2024

Choose a reason for hiding this comment

anomiex Sep 10, 2024

Choose a reason for hiding this comment

anomiex Sep 10, 2024

Choose a reason for hiding this comment

zinigor Sep 10, 2024

Choose a reason for hiding this comment

anomiex Sep 10, 2024

Choose a reason for hiding this comment

zinigor Sep 10, 2024

Choose a reason for hiding this comment

anomiex Sep 10, 2024

Choose a reason for hiding this comment

zinigor left a comment

Choose a reason for hiding this comment

Update `@wordpress/eslint-plugin` #39305

Update `@wordpress/eslint-plugin` #39305

github-actions bot commented Sep 9, 2024 •

edited

Loading

github-actions bot commented Sep 9, 2024 •

edited

Loading