-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update @wordpress/eslint-plugin
#39305
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Significance: patch | ||
Type: fixed | ||
|
||
Remove unnecessary leading space from i18n message. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Significance: patch | ||
Type: fixed | ||
|
||
Use en-dash in numeric range in i18n message to conform to guidelines. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Significance: patch | ||
Type: fixed | ||
|
||
Move trailing spaces out of i18n messages. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Significance: patch | ||
Type: other | ||
|
||
Move leading and trailing spaces out of i18n messages. Use en-dash for numeric ranges in i18n messages. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Significance: patch | ||
Type: fixed | ||
|
||
Remove unnecessary trailing space from i18n message. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Significance: patch | ||
Type: fixed | ||
|
||
Move leading and trailing spaces out of i18n messages. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,7 +70,7 @@ const ShareDebugData = () => { | |
|
||
return ( | ||
<div className={ styles[ 'share-data-section' ] }> | ||
<Title mb={ 2 }>{ __( ' Share detailed data with Jetpack', 'jetpack-protect' ) }</Title> | ||
<Title mb={ 2 }>{ __( 'Share detailed data with Jetpack', 'jetpack-protect' ) }</Title> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Have you been able to figure out why there was a space here in the first place? Maybe we should preserve this one too? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seems to go back to 021eb6a, beyond that I have no idea. It made no difference to the rendering when I tried it. HTML ignores whitespace at the start of block elements like the |
||
<div className={ styles[ 'footer-checkbox' ] }> | ||
<CheckboxControl | ||
checked={ Boolean( settings.jetpack_waf_share_debug_data ) } | ||
|
@@ -114,7 +114,7 @@ const ShareData = () => { | |
|
||
return ( | ||
<div className={ styles[ 'share-data-section' ] }> | ||
<Title mb={ 2 }>{ __( ' Share basic data with Jetpack', 'jetpack-protect' ) }</Title> | ||
<Title mb={ 2 }>{ __( 'Share basic data with Jetpack', 'jetpack-protect' ) }</Title> | ||
<div className={ styles[ 'footer-checkbox' ] }> | ||
<CheckboxControl | ||
checked={ Boolean( settings.jetpack_waf_share_data ) } | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,7 +33,7 @@ const ProductPromotion = () => { | |
<Title>{ __( 'Get access to our Cloud', 'jetpack-protect' ) }</Title> | ||
<Text mb={ 3 }> | ||
{ __( | ||
'With your Protect upgrade, you have free access to scan your site on our Cloud, so you can be aware and fix your threats even if your site goes down. ', | ||
'With your Protect upgrade, you have free access to scan your site on our Cloud, so you can be aware and fix your threats even if your site goes down.', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm afraid we'll have to preserve this too for inline elements. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
'jetpack-protect' | ||
) } | ||
</Text> | ||
|
@@ -83,9 +83,9 @@ const FooterInfo = () => { | |
<Title>{ __( 'Line-by-line scanning', 'jetpack-protect' ) }</Title> | ||
<Text mb={ 2 }> | ||
{ __( | ||
'We actively review line-by-line of your site files to identify threats and vulnerabilities. Jetpack monitors millions of websites to keep your site secure all the time. ', | ||
'We actively review line-by-line of your site files to identify threats and vulnerabilities. Jetpack monitors millions of websites to keep your site secure all the time.', | ||
'jetpack-protect' | ||
) } | ||
) }{ ' ' } | ||
<Button variant="link" target="_blank" weight="regular" href={ learnMoreScanUrl }> | ||
{ __( 'Learn more', 'jetpack-protect' ) } | ||
</Button> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
Significance: patch | ||
Type: fixed | ||
|
||
Move trailing space out of i18n message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we put the space inside the
span
element to preserve the original behavior?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷 No idea. In practice CSS currently sets
display: block
on these spans so the whitespace gets ignored either way.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before:
After: