-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ras-acc): respect social icons padding #1615
fix(ras-acc): respect social icons padding #1615
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## epic/ras-acc #1615 +/- ##
==================================================
+ Coverage 19.63% 19.67% +0.03%
- Complexity 2372 2378 +6
==================================================
Files 45 45
Lines 8926 8930 +4
==================================================
+ Hits 1753 1757 +4
Misses 7173 7173 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I couldn't spot any noticeable difference between the before and after in newsletters.
All Submissions:
Changes proposed in this Pull Request:
Closes https://app.asana.com/0/1207817176293825/1207990881852220/f
This PR addresses an issue where the renderer was not not respecting the social icons padding set in the editor. This also tweaks the default icons padding to 8px (from 7px) to be in-line with the spacing set in RAS-ACC transactional emails:
Editor:
Email:
How to test the changes in this Pull Request:
To test this PR, be sure to also checkout the following plugin PR: Automattic/newspack-plugin#3339
See Automattic/newspack-plugin#3339 for testing RAS-ACC specific behavior
trunk
Note that social icons in newsletters is currently a bit funky on
trunk
. This PR does not fix this and only focuses on changes for RAS-ACC.Other information: