Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ras-acc): respect transactional email social icons alignment #3339

Merged

Conversation

chickenn00dle
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

Closes https://app.asana.com/0/1207817176293825/1207990881852220/f

This PR fixes an issue where the alignment of the transactional email social icons did not line up with the rest of the email content. This PR addresses this by adding a left and right padding of 0 to the social icons:

Screenshot 2024-08-14 at 14 58 26

How to test the changes in this Pull Request:

To test this PR, be sure to also check out the following newsletters PR first: Automattic/newspack-newsletters#1615

  1. Be sure you have Yoast installed and active and have some socials added via Newspack > SEO
  2. Reset any of the transactional emails via Newspack > Engagement > Show Advanced Settings > Transactional Email Content
  3. Select edit for the corresponding email template and confirm the alignment of the social icons as pictured above
  4. Send a test email, or trigger the email as a reader and confirm the alignment in the actual email.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@chickenn00dle chickenn00dle force-pushed the fix/transaction-emails-social-icons-alignment branch from f3465d7 to c1b8c84 Compare August 14, 2024 20:25
@chickenn00dle chickenn00dle added the [Status] Needs Review The issue or pull request needs to be reviewed label Aug 14, 2024
Copy link
Contributor

@laurelfulford laurelfulford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The editor and sent emails look good! 👍

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Aug 15, 2024
@chickenn00dle chickenn00dle merged commit a21eb6f into epic/ras-acc Aug 15, 2024
9 checks passed
@chickenn00dle chickenn00dle deleted the fix/transaction-emails-social-icons-alignment branch August 15, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ras-acc testing [Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants