Initial Commit of Clean Slate #6665
Conversation
The first commit of the Clean Slate theme, a blank/starter theme.
Initial commit stuck at delta. will re-commit the fonts
This reverts commit e2653f7.
|
I think if we want a truly clean slate we should remove a lot more - all the patterns for example can go, and quite a few of the templates as well. |
Removed all patterns from the theme
|
What happens if we remove all templates except index? |
Tbh makes sense. @mtias this is also something along the lines of what you've expressed for this right? |
|
I'm also wondering about the inclusion of font assets. What do you think about removing them and reverting to using system fonts? |
|
Could we have the |
Missing new lines in templates and parts added
Removed "Template:" declaration line in style.css since this is not a child theme.
Removed all custom fonts bundled with the theme
Per the decision on the name, this will be the replacement of Blank Canvas
| }, | ||
| "link": { | ||
| "color": { | ||
| "text": "var(--wp--preset--color--primary)" |
There was a problem hiding this comment.
It might be interesting to use ref properties, to reduce the duplication: WordPress/gutenberg#41696
There was a problem hiding this comment.
Hi @scruffian could you elaborate on this? Is do I simply use the following? Because when I did, the theme.json and the theme style breaks. I also don't understand the reason fully even though I've read the PR.
"link": {
"color": {
"text": { ref: "styles.color.primary" }
},
There was a problem hiding this comment.
Try using:
"color": {
"text": { ref: "styles.color.text" }
},
The reason being that if a user changes their body text color then links will update automatically.
|
I'm not clear how "blank" we want this to be. The templates still contain a lot of opinion. Do we want to strip it back to just display page content? |
blank-canvas-3/theme.json
Outdated
| @@ -0,0 +1,360 @@ | |||
| { | |||
| "customTemplates": [ | |||
There was a problem hiding this comment.
I think the customTemplates config can be removed since there is no longer a blank template supplied by the theme.
Removed custom templates declarations from the theme.json file
This PR introduces the Clean Slate theme, a blank/starter theme in replacement of Blank Canvas, started out with the purpose of using in Pattern Assembler project.
This theme is a stripped down version of TT3 theme, with some more custom theme.json and template parts updates.
I've kept the fonts from TT3, as the use of a fonts library for this theme TBD.
Please let me know what could be improved with this theme, as I'm still checking for things that may be needed to be updated.
Thank you!