-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "showing latest posts" wording when a non-blog theme uses home.html for static content #69171
Comments
#69070 has addressed this issue, it will show the Home page (Home template) and the empty page section will be gone |
That was just occurring to me. GREAT! :) |
What if the Reading setting is set to "static page", but the user adds a Front Page template? Should we show a virtual page? The homepage will display that Front Page template, but right now, in @arthur791004 's PR, the Pages list is still incorrect: (Here, the Test Page is set as the static page. However, it is misleading as the homepage is actually the Front Page template) |
|
Maybe we can open a new issue for this (the Front Page case), as currently this problem shows up even on production (without the PR). But it means we need to modify Arthur's PR, because the PR assumes that the homepage template is always Home template. |
I think it's a bug, and it has to show the template used by the Home page 🤔 Additionally, I saw query block is showing the posts in the site editor, but it's showing the pages when I'm visiting the site...so I don't notice my home page is showing the Front Page template 😂 |
No it's not a bug. It's the expected behavior according to the template hierarchy. Front Page overrides everything if it exists. Ref: https://developer.wordpress.org/themes/basics/template-hierarchy/#front-page-display |
Oh yes, that's why we want to avoid using Front Page template 😭 |
@arthur791004 @fushar
Yes we should show a virtual page but this has nothing to do with the PA project. Please make an issue for this and put in post MVP. Anything that isn't related to the PA project, please file a bug and indicate what you think the priority is. Also can we agree on a consistent and exact terminology:
|
Sorry I think this discussion should be on #69158 instead; didn't realize that there are multiple issues here 😂 |
You can add a link from that issue to this one @fushar so trail of discussion is clear. I think we can close this now, ya? |
Yup, done!
I think so. cc @arthur791004 |
Close it 🙂 |
Description
This copy "The homepage is showing your latest posts." makes no sense in the context of themes that:
UDPATE: I think this should apply to all FSE themes, but need to get confirmation from a theme developer.
As far as I'm aware this includes (Pendant, Cultivate, Archeo, Yuga) and the new Blank Canvas
Testing
see https://ganonp2.wordpress.com/2022/10/14/reviewing-the-theme-switch-modal-messaging/#comment-1909 for testing flow
The text was updated successfully, but these errors were encountered: