Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "showing latest posts" wording when a non-blog theme uses home.html for static content #69171

Closed
autumnfjeld opened this issue Oct 18, 2022 · 14 comments
Assignees

Comments

@autumnfjeld
Copy link
Contributor

autumnfjeld commented Oct 18, 2022

Description

This copy "The homepage is showing your latest posts." makes no sense in the context of themes that:

  • don't have a "real" page
  • use home.html for page content

UDPATE: I think this should apply to all FSE themes, but need to get confirmation from a theme developer.

As far as I'm aware this includes (Pendant, Cultivate, Archeo, Yuga) and the new Blank Canvas

Image

Testing

see https://ganonp2.wordpress.com/2022/10/14/reviewing-the-theme-switch-modal-messaging/#comment-1909 for testing flow

  • activate any theme that satisfies the described constraints, see that the virtual page shows instead of "The homepage is showing your latest posts."
  • classic themes should still display this message "The homepage is showing your latest posts."
@arthur791004
Copy link
Contributor

arthur791004 commented Oct 18, 2022

#69070 has addressed this issue, it will show the Home page (Home template) and the empty page section will be gone

@autumnfjeld
Copy link
Contributor Author

That was just occurring to me. GREAT! :)

@fushar
Copy link
Contributor

fushar commented Oct 19, 2022

@autumnfjeld @arthur791004

What if the Reading setting is set to "static page", but the user adds a Front Page template? Should we show a virtual page?

The homepage will display that Front Page template, but right now, in @arthur791004 's PR, the Pages list is still incorrect:

image

(Here, the Test Page is set as the static page. However, it is misleading as the homepage is actually the Front Page template)

@arthur791004
Copy link
Contributor

What if the Reading setting is set to "static page", but the user adds a Front Page template? Should we show a virtual page?
The homepage will display that Front Page template,

I tested but my homepage is my Home Page. How do you see the Front Page template as the homepage?

image

@fushar
Copy link
Contributor

fushar commented Oct 19, 2022

  • Go to /site-editor/<siteSlug>, the template will be Front Page
  • Or just visit the site directly, the content of the Front Page template will be used

@fushar
Copy link
Contributor

fushar commented Oct 19, 2022

Maybe we can open a new issue for this (the Front Page case), as currently this problem shows up even on production (without the PR).

But it means we need to modify Arthur's PR, because the PR assumes that the homepage template is always Home template.

@arthur791004
Copy link
Contributor

I think it's a bug, and it has to show the template used by the Home page 🤔

Additionally, I saw query block is showing the posts in the site editor, but it's showing the pages when I'm visiting the site...so I don't notice my home page is showing the Front Page template 😂

@fushar
Copy link
Contributor

fushar commented Oct 19, 2022

I think it's a bug, and it has to show the template used by the Home page

No it's not a bug. It's the expected behavior according to the template hierarchy. Front Page overrides everything if it exists. Ref: https://developer.wordpress.org/themes/basics/template-hierarchy/#front-page-display

@arthur791004
Copy link
Contributor

Oh yes, that's why we want to avoid using Front Page template 😭

@autumnfjeld
Copy link
Contributor Author

@arthur791004 @fushar
To summarize:

  • The Reading settings are for selecting a WP page, not a template (noting that for my own clarification)
  • In the PA flow, Blank Canvas, or any other theme will never use front-page template, because of @fushar's point above, the template hierarchy
  • if the user chooses to add a front-page.html template, we should have consistency in the calypso UI
    • if this is a pre-existing bug, please file a new issue
    • we don't need to worry about this for the PA project, because the PA project has a very well defined setup (it doesn't use front-page.html)

What if the Reading setting is set to "static page", but the user adds a Front Page template? Should we show a virtual page?

Yes we should show a virtual page but this has nothing to do with the PA project. Please make an issue for this and put in post MVP.

Anything that isn't related to the PA project, please file a bug and indicate what you think the priority is.


Also can we agree on a consistent and exact terminology:

  • homepage = what the user sees on their root page mysite.com/
  • home.html = the home template which in PA case will show as a virtual page
  • Home page = an actual wordpress page (that is how I would read it) or maybe we should use the term Home WPpage 😄

@fushar
Copy link
Contributor

fushar commented Oct 20, 2022

Sorry I think this discussion should be on #69158 instead; didn't realize that there are multiple issues here 😂

@autumnfjeld
Copy link
Contributor Author

You can add a link from that issue to this one @fushar so trail of discussion is clear.

I think we can close this now, ya?

@fushar
Copy link
Contributor

fushar commented Oct 24, 2022

You can add a link from that issue to this one @fushar so trail of discussion is clear.

Yup, done!

I think we can close this now, ya?

I think so. cc @arthur791004

@arthur791004
Copy link
Contributor

Close it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants