Use local git repository to get git diffs #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariskataoka
reviewed
Mar 25, 2021
ariskataoka
reviewed
Apr 14, 2021
| function vipgoci_git_version(): ?string { | ||
| static $git_version_cached = null; | ||
|
|
||
| if ( null !== $git_version_cached ) { |
| string $commit_id_b | ||
| ): array { | ||
|
|
||
| vipgoci_log( |
There was a problem hiding this comment.
I think these tabs and break lines were unintentional?
There was a problem hiding this comment.
Resolved in d1471e7
I'm assuming you are referring to line 779 (now removed). The tabs on line 781, 782 and so forth are intentional to make the code easier to read.
vipgoci_gitrepo_diffs_fetch_uncached(): * Overall statistics on changes * For files renamed, previous file name is provided vipgoci_gitrepo_diffs_fetch(): * Overall statistics on changes, takes into account filters
6 tasks
There was a problem hiding this comment.
phpcs scanning turned up:
This bot provides automated PHP Linting and PHPCS scanning, read more here.
git-repo.php
Outdated
| 'commit_id_b' => $commit_id_b, | ||
| ) | ||
| ); | ||
| $test = ''; |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let
vipgoci_github_diffs_fetch()use local git repository for its source ofgit diffresults instead of using the GitHub API. Rename the function to indicate that it uses the local git-repository as well. Add unit-tests as needed and update older ones.This will solve #135 .
TODO:
MiscPatchChangedLinesTestunit-test to use thevip-go-ci-testsrepository, see here.vipgoci_github_diffs_fetch()into two: cached and uncached versionsvipgoci_github_diffs_fetch()tovipgoci_gitrepo_diffs_fetch()and move togit-repo.php.a/andb/vipgoci_gitrepo_diffs_fetch_uncached()-- overall statistics on changes, previous name of files renamedvipgoci_gitrepo_diffs_fetch()-- overall statistics on changes, takes effects of filter into account