Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with vipgoci_gitrepo_blame_for_file() #158

Merged
merged 9 commits into from
Apr 23, 2021
Merged

Fix bug with vipgoci_gitrepo_blame_for_file() #158

merged 9 commits into from
Apr 23, 2021

Conversation

gudmdharalds
Copy link
Contributor

@gudmdharalds gudmdharalds commented Apr 19, 2021 •
edited
Loading

Fix bug with vipgoci_gitrepo_blame_for_file() which can lead to changes being excluded from reporting.

TODO:

  • Fix bug in vipgoci_gitrepo_blame_for_file() so that the correct line number is used from the git blame log
  • Review the code to ensure the fix does not lead to unexpected behaviour
  • Add unit-test to test bugfix
  • Run full-unit tests
  • Check automated unit-tests
  • More testing

This was discovered while working on #153.

@gudmdharalds gudmdharalds self-assigned this Apr 19, 2021
@gudmdharalds
Copy link
Contributor Author

This will resolve #90.

@gudmdharalds gudmdharalds merged commit a5ba3c9 into master Apr 23, 2021
@gudmdharalds gudmdharalds mentioned this pull request Apr 23, 2021
Closed
@gudmdharalds gudmdharalds deleted the fix-gitrepo-blame-for-file branch April 30, 2021 15:20
@gudmdharalds gudmdharalds added this to the 1.0.0 milestone May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gudmdharalds gudmdharalds

Labels
[Type] Bug
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@gudmdharalds