Call htmlentities() with PHP 8.1 defaults #298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request ensures that all calls to
htmlentities()
are made with default PHP 8.1 parameters. In PHP 8.1, the$flags
parameter is by defaultENT_QUOTES | ENT_SUBSTITUTE | ENT_HTML401
, while in PHP 8.0 it is by defaultENT_COMPAT
(see documentation). This project aims to support both PHP 8.0 and 8.1, and so to ensure the code behaves the same with both PHP versions, this change is needed.The incompatibility was discovered while resolving #297.
TODO:
htmlentities()
are made with PHP 8.1 defaults.