Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virtual home.html link in Calypso pages #69158

Closed
1 task done
autumnfjeld opened this issue Oct 18, 2022 · 5 comments
Closed
1 task done

Add virtual home.html link in Calypso pages #69158

autumnfjeld opened this issue Oct 18, 2022 · 5 comments
Assignees

Comments

@autumnfjeld
Copy link
Contributor

autumnfjeld commented Oct 18, 2022

Description

For MVP of the Pattern Assembler we have a number of "supporting work" items to make the user experience smoother. One of these items is surfacing "virtual pages" in https://wordpress.com/pages.
Spike completed. [Spike] Surfacing virtual pages in the wordpress.com/pages UI

This issue defines what will ship to users. See @arthur791004 's video demo: p1666004346238589/1665657784.022599-slack-CRWCHQGUB

image

Specs

  • Show “Home” template in pages section if the homepage display is setting to “latest posts”
  • It supports “Edit”, “View page” and “Copy link” actions
  • It has :info: icon next to the title, and indicates this one is “Home” template, and only part of actions are supported. Customers can click “Learn more” link to see details.
  • It has the “homepage” badge below the title
  • The “Home” template is searchable
  • Consider home.html a "published page" in terms of "published page counts" - expect this to change as we get input or in CfT beca

Open questions

  • Do we need to increase the count of the published pages by 1?
  • The virtual page won't have same "menu options" as other pages. Is this a big deal?

Dev tasks

Testing

  • when the feature is updated, create another movie that we can share to get copy approval
@autumnfjeld
Copy link
Contributor Author

@arthur791004 you can link any PRs here to this issue. :)

@arthur791004
Copy link
Contributor

Copy: "The homepage of your site displays the Home template[link to template editor or site editor]

When the user clicks on the Home page, they will enter the site editor. Do we still need to link the description to to the site editor?

Learn more: what should we link to? https://wordpress.com/support/full-site-editing/ or directly to the Templates page here: https://wordpress.com/support/templates/

I link it to https://wordpress.com/support/templates/#template-hierarchy because it describes “If your site is set up to display the latest posts on the front page, the Home or Index template applies the style for that page.” below. Does it make sense?

@arthur791004
Copy link
Contributor

I've made a change to update the copy and only apply to the themes that support FSE.

Here is new demo.

@fushar
Copy link
Contributor

fushar commented Oct 20, 2022

Added a new issue for the Front Page template case: #69282.

See the original discussion here: #69171 (comment)

@autumnfjeld
Copy link
Contributor Author

@arthur791004 One more question about the "rules" for showing a virtual page. See discussion, what Saxon said about this should only apply to block themes. p1666565049015129-slack-CRWCHQGUB

Are we limiting this to block themes only? e.g. in #69070

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants