Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for different user for Gutenberg edge testing #38292

Merged
merged 2 commits into from
Dec 9, 2019
Merged

Add support for different user for Gutenberg edge testing #38292

merged 2 commits into from
Dec 9, 2019

Conversation

bsessions85
Copy link
Contributor

Changes proposed in this Pull Request

  • This PR adds the option to use a different user for the Gutenberg tests when the GUTENBERG_EDGE env variable

Testing instructions

  • Decrypt updated config file and ensure that the new e2eflowtestinggutenbergsimpleedge user is present
  • Run Gutenberg tests and make sure they run with the user e2eflowtestinggutenbergsimple
  • Set GUTENBERG_EDGE=true and run the Gutenberg tests again. Make sure they now use e2eflowtestinggutenbergsimpleedge

Related to the work being done in Automattic/wp-e2e-tests-gh-bridge#82

@bsessions85 bsessions85 requested a review from a team as a code owner December 9, 2019 16:17
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=add/gutenberg-edge-e2e

@bsessions85 bsessions85 self-assigned this Dec 9, 2019
@bsessions85 bsessions85 added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 9, 2019
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Stojdza
Stojdza approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@Stojdza Stojdza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works good after the latest change! 🚀

@bsessions85 bsessions85 merged commit 72d2e4b into master Dec 9, 2019
@bsessions85 bsessions85 deleted the add/gutenberg-edge-e2e branch December 9, 2019 17:54
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stojdza Stojdza Stojdza approved these changes

Assignees

@bsessions85 bsessions85

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bsessions85 @matticbot @Stojdza