Add: webhook handling for gutenberg edge label #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsessions85
approved these changes
Dec 9, 2019
|
Thanks @bsessions85! Are there any follow up steps after merging? |
|
@gwwar I have calypso and wrapper repo changes out too. This should be ready to go! |
|
Awesome, @bsessions85 we'll give it a try! |
13 tasks
Stojdza
reviewed
Dec 24, 2019
| const envVars = { SKIP_DOMAIN_TESTS: true, GUTENBERG_EDGE: true }; | ||
| description = 'The e2e full WPCOM suite desktop tests are running against your PR with the latest snapshot of Gutenberg'; | ||
| log.info( 'Executing CALYPSO e2e full WPCOM suite desktop tests for with gutenberg edge branch: \'' + branchName + '\'' ); | ||
| executeCircleCIBuild( 'false', '', '', e2eBranchName, pullRequestNum, 'ci/wp-e2e-tests-full-desktop-edge', '-s desktop -g', description, sha, false, calypsoProject, null, envVars ); |
There was a problem hiding this comment.
@bsessions85 Is there a reason why we don't run tests against live branch for Gutenberg edge user? We had a situation where test was failing on a PR because it was looking for the selector which was introduced in that same PR Automattic/wp-calypso#38507 (comment)
There was a problem hiding this comment.
No, just an oversight. We were only running on horizon before, so didn't think about using live branches for it. It should be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Let's trigger a full desktop and mobile E2E run using a special test site that has the
gutenberg-edgeblog sticker. This loads the latest version of the Gutenberg plugin we're testing in all views (iframe/wp-admin/published) so we should be able to add more types of E2E tests!gutenberg-edgesticker