WPCOM Block Editor: Fix incorrect editor position on mobile #38388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copons
added
[Type] Bug
[Feature] Post/Page Editor
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
mmtr
approved these changes
Dec 13, 2019
There was a problem hiding this comment.
Nice! I verified this fixes the layout on Simple, Jetpack and Atomic sites. I also checked this doesn't break the layout when a Jetpack or Atomic site runs an older version of Gutenberg.
I noted that the placeholder is still misaligned, but totally unrelated to this PR:
Copons
force-pushed
the
fix/gutenframe-mobile-top-offset
branch
from
4d45a21
to
511e4ea
Compare
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
WordPress/gutenberg#18686 changed how the editor is positioned on mobile.
In Core the admin bar is always visible, even in fullscreen mode.
In WPCOM, instead, the admin bar is never visible, so we don't need the
topoffset for it.This PR sets
top: 0to the elements affected by the changes in Gutenberg 7.1.0 (at least those that I've noticed).I've also removed a couple of rules that aren't applicable anymore, as
.edit-post-layout__contenthas been recently removed.Testing instructions
Pre-requisites:
widgets.wp.com.Test: