Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Check homepage can be edited on Gutenberg after sign up #38765

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented Jan 10, 2020

Changes proposed in this Pull Request

Adds an extra step to the sign up for a free/premium site tests that verifies there are no block errors when editing the homepages of the new created sites.

Fixes #38383

@mmtr mmtr added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 10, 2020
@mmtr mmtr requested a review from a team as a code owner January 10, 2020 15:21
@mmtr mmtr self-assigned this Jan 10, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~24 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
woocommerce        +29 B  (+0.0%)      +13 B  (+0.0%)
plans              +29 B  (+0.0%)      +11 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~47 bytes added 📈 [gzipped])

name                                                         parsed_size           gzip_size
async-load-my-sites-checklist-wpcom-checklist-component-jsx        +54 B  (+0.0%)      +21 B  (+0.1%)
async-load-design-playground                                       +29 B  (+0.0%)       +9 B  (+0.0%)
async-load-design-blocks                                           +29 B  (+0.0%)       +4 B  (+0.0%)
async-load-design                                                  +29 B  (+0.0%)      +13 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@mmtr mmtr requested a review from a team January 10, 2020 15:49
@mmtr mmtr added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 10, 2020
Copy link
Contributor

@gwwar gwwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmtr ! Code here looks good, I also confirmed that the selector is correct for an invalid block.

@mmtr mmtr merged commit 9feb01a into master Jan 13, 2020
@mmtr mmtr deleted the update/e2e-signup-gutenberg branch January 13, 2020 09:39
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gutenberg: Add E2E test to smoke test block invalidation error on default templates
3 participants