Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg 7.2.0: Update E2E tests #38507

Merged
merged 2 commits into from
Jan 13, 2020
Merged

Gutenberg 7.2.0: Update E2E tests #38507

merged 2 commits into from
Jan 13, 2020

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented Dec 18, 2019

Changes proposed in this Pull Request

Updates some CSS selectors and texts in order to match the new classes and sentence case changes introduced in Gutenberg 7.2.0.

@mmtr mmtr added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. DO NOT MERGE [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot labels Dec 18, 2019
@mmtr mmtr requested a review from a team December 18, 2019 12:43
@mmtr mmtr self-assigned this Dec 18, 2019
@matticbot
Copy link
Contributor

@mmtr
Copy link
Member Author

mmtr commented Dec 18, 2019

Seems that tests are currently failing due to WordPress/gutenberg#19050

Some classes have changed so we need to update the selectors.

@matticbot
Copy link
Contributor

matticbot commented Dec 18, 2019

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~140567 bytes removed 📉 [gzipped])

name        parsed_size            gzip_size
entry-main    -639110 B  (-39.8%)  -140567 B  (-35.9%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~46051 bytes removed 📉 [gzipped])

name             parsed_size             gzip_size
post-editor        -627968 B   (-32.8%)  -156776 B   (-30.0%)
reader             +547244 B  (+139.2%)  +137482 B  (+136.3%)
theme              -139480 B   (-35.3%)   -30798 B   (-31.5%)
media              +138863 B   (+37.9%)   +22218 B   (+23.1%)
marketing          -106563 B   (-25.1%)   -21476 B   (-20.8%)
home                 +6402 B    (+2.5%)    +2322 B    (+3.5%)
themes               -2785 B    (-0.9%)     +329 B    (+0.4%)
plugins              -2785 B    (-0.6%)     +329 B    (+0.3%)
hosting              -2785 B    (-1.2%)     +329 B    (+0.5%)
jetpack-connect      -1733 B    (-0.3%)      -10 B    (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@mmtr mmtr requested a review from a team as a code owner December 18, 2019 14:09
@mmtr mmtr changed the title Gutenberg 7.2.0: Placeholder PR for running E2E tests Gutenberg 7.2.0: Fix E2E tests Dec 18, 2019
@mmtr mmtr removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 18, 2019
@mmtr mmtr changed the title Gutenberg 7.2.0: Fix E2E tests Gutenberg 7.2.0: Update E2E tests Dec 23, 2019
@mmtr mmtr requested a review from a team December 23, 2019 15:11
@mmtr
Copy link
Member Author

mmtr commented Dec 23, 2019

Uhm, not sure why the new step is currently failing with Timed out waiting for element with css selector of '.customer-home__layout button[data-e2e-action="update-homepage"]' to be clickable.

When running Calypso locally, that selector is valid, so I wonder if the test is running against a stale image.

Screenshot 2019-12-23 at 16 56 54

@mmtr mmtr added [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot and removed [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot labels Dec 23, 2019
@Stojdza
Copy link
Contributor

Stojdza commented Dec 23, 2019

@mmtr I tried Basic sign up for a free site @signup @email @ie11canary test locally against WP.com and against live branch from this PR. The result - test is passing against live branch and it's failing against WP.com. Which is expected, since data-e2e-action="update-homepage" is introduced in this PR.

That's why I added [Status] Needs e2e Testing label to see what will happen. Tests triggered with this label will run against live branch for sure, and Basic sign up for a free site @signup @email @ie11canary has passed. My assumption that tests triggered with edge label don't run against live branch. Instead, they run against WP.com and that's the reason why it fails. I will take a look at this problem in the next days. You're good to go with these changes 👍

Differences from CircleCI:

[Status] Needs e2e Testing Gutenberg Edge label:

Screen Shot 2019-12-23 at 17 44 36

[Status] Needs e2e Testing label:

Screen Shot 2019-12-23 at 17 44 44

@mmtr
Copy link
Member Author

mmtr commented Dec 24, 2019

Awesome, thanks for clarifying @Stojdza!

@jeraldjuice jeraldjuice added [Status] Needs e2e Testing [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot and removed [Status] Needs e2e Testing [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot labels Dec 28, 2019
@mmtr mmtr added the [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot label Jan 7, 2020
@kwight kwight added [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot and removed [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot labels Jan 7, 2020
@mmtr mmtr added [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot and removed [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot labels Jan 8, 2020
@mmtr mmtr added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot and removed [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 9, 2020
@kwight
Copy link
Contributor

kwight commented Jan 10, 2020

Can we keep the new revisions test in a separate PR, and have this PR remain only what's needed to get the plugin updates to pass?

@@ -52,6 +48,14 @@ export default class GutenbergEditorComponent extends AsyncBaseContainer {
await this.driver.sleep( 2000 );
}

async initEditor( { dismissPageTemplateSelector = false } = {} ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it <3

@mmtr
Copy link
Member Author

mmtr commented Jan 10, 2020

Can we keep the new revisions test in a separate PR, and have this PR remain only what's needed to get the plugin updates to pass?

Thanks for the suggestion @kwight. Small PRs for the win!

Moved all new steps and tests that are unrelated to the Gutenberg update to separate PRs:

@mmtr mmtr force-pushed the try/gutenberg-7.2.0-e2e branch 3 times, most recently from 21af37d to f3d0d4e Compare January 13, 2020 09:57
@mmtr mmtr added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jan 13, 2020
@mmtr mmtr added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot DO NOT MERGE labels Jan 13, 2020
@mmtr
Copy link
Member Author

mmtr commented Jan 13, 2020

We needed to remove the basic publish post test from the IE11 canary test suite since it was failing and we didn't want to block the Gutenberg update.

We'll investigate later what was causing the failure.

@mmtr mmtr merged commit 721e4f5 into master Jan 13, 2020
@mmtr mmtr deleted the try/gutenberg-7.2.0-e2e branch January 13, 2020 15:34
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 13, 2020
mmtr added a commit that referenced this pull request Jan 15, 2020
In #38767 we added the Gutenberg basic publish posts to the IE11 canary test suite in order to prevent more IE11 regressions from happening.

However, we had to remove it in #38507 after activating Gutenberg 7.2.0 since the test was failing for some reason.

This PR adds that test back and properly fixes the test by adding some missing awaits (props @Stojdza)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants