Update: marketing sharing buttons view for Sharing Buttons block

[andrii-lysenko]

Related to Automattic/jetpack#34327

Proposed Changes

This changes the behavior of /marketing/sharing-buttons/:site page by adding new view, that will refclect new usage of the Sharing Buttons Block.
Some important notices:

• New feature flag added jetpack/sharing-buttons-block-enabled. This is now available only for Dev environment.
• New view is visible only if site has a block-based theme
• Additionally added a check for no-block-appearance query arg if we would want to use it.
• Learn how to add Sharing Buttons button is not functional are the Docs aren't ready yet.

Testing Instructions

• Spin up a new JN site
• Run the branch locally or use Live links
• Navigate to /marketing/sharing-buttons/:site (add ?flags=jetpack/sharing-buttons-block-enabled if using Live Link)
• You should see the new screen. Check it's behavior.
• Check with param &no-block-appearance=true in the url, old screen should show up.
• Test on classic theme (eg Twenty Ten). You should see old screen.
• Test on Simple/Atomic

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-91059

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-91059&env=jetpack

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• blaze-dashboard
• odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/marketing-sharing-buttons-view on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~486 bytes added 📈 [gzipped])

name       parsed_size           gzip_size
marketing      +1958 B  (+0.3%)     +486 B  (+0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[monsieur-z]

All the cases tested well, and the code changes look sensible.

I'm wondering if the Go to the Site Editor link could link to a more specific section inside the Site Editor, to provide a better experience.

[andrii-lysenko]

@monsieur-z Thanks for the review. I was wondering of that as well, though, I'm not aware of how we could achieve this for now. For now, it's the best we can do I think (Automattic/jetpack#34327 (comment))

[keoshi]

LGTM!

[andrii-lysenko]

Haven't made this change, but disabled the rule to be able to commit my changes.

[a8ci18n]

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/10298298

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @andrii-lysenko for including a screenshot in the description! This is really helpful for our translators.

[a8ci18n]

Translation for this Pull Request has now been finished.