-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sharing: open up sharing block recommendations #88294
Conversation
Until now this was behind a flag. Let's instead display it all the time, as long as you use either WordPress.com or a version of Jetpack that includes the block.
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~174 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks reasonable and intuitive for me 👍
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/11592784 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @jeherve for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
* Sharing buttons: display block interface when block is supported Until now this was behind a flag. Let's instead display it all the time, as long as you use either WordPress.com or a version of Jetpack that includes the block. * Display link to support docs in block button screen * Add logic to offering disabling the legacy sharing feature * fix module deactivation * Add missing block theme check
Follow-up to #85180
Related:
Proposed Changes
Now that the sharing buttons block is widely available, both on WordPress.com Simple and on stable Jetpack releases, we can remove the previous flag and display the new screen to everyone, as long as they're on WordPress.com or using a recent version of Jetpack (the sharing buttons block was added to the plugin in version 13.1).
This PR also does a few other things:
Testing Instructions
Note
It's important to test this change on both WordPress.com and Jetpack sites, on sites that use a classic theme and sites that use a block-based theme.
http://calypso.localhost:3000/marketing/sharing-buttons/
Jetpack, block-based theme, legacy sharing module active
Jetpack, block-based theme, legacy sharing module inactive
Jetpack, classic theme, legacy sharing module active
-> No changes to that scenario
Jetpack, classic theme, legacy sharing module inactive
-> No changes to that scenario
WordPress.com, block-based theme
WordPress.com, classic theme
-> No changes to that scenario
Pre-merge Checklist