Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing: open up sharing block recommendations #88294

Merged
merged 5 commits into from
Mar 11, 2024

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Mar 7, 2024

Follow-up to #85180

Related:

Proposed Changes

Now that the sharing buttons block is widely available, both on WordPress.com Simple and on stable Jetpack releases, we can remove the previous flag and display the new screen to everyone, as long as they're on WordPress.com or using a recent version of Jetpack (the sharing buttons block was added to the plugin in version 13.1).

This PR also does a few other things:

  • It updates the look of the sharing buttons block recommendation screen to link to the support docs, with an external link button, and with the right doc depending on your platform.
  • It updates the wording on the sharing screen to try to make it clearer that the blocks is what you want to go with when using a block-based theme.
  • It offers a quick option to deactivate the sharing module when you use a block-based theme.

Testing Instructions

Note

It's important to test this change on both WordPress.com and Jetpack sites, on sites that use a classic theme and sites that use a block-based theme.

  • On a self-hosted site, go to Jetpack > Settings > Sharing and activate the sharing module.
  • Go to http://calypso.localhost:3000/marketing/sharing-buttons/
    • Ensure the display is relevant to the state of your site, following the screenshots below.`

Jetpack, block-based theme, legacy sharing module active

image

Jetpack, block-based theme, legacy sharing module inactive

image

Jetpack, classic theme, legacy sharing module active

-> No changes to that scenario

image

Jetpack, classic theme, legacy sharing module inactive

-> No changes to that scenario

image

WordPress.com, block-based theme

image

WordPress.com, classic theme

-> No changes to that scenario

image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

Until now this was behind a flag. Let's instead display it all the time, as long as you use either WordPress.com or a version of Jetpack that includes the block.
@jeherve jeherve added [Type] Enhancement [Feature] Sharing Features and settings for sharing posts across different platforms, including sharing buttons. [Pri] Normal [Status] In Progress labels Mar 7, 2024
@jeherve jeherve self-assigned this Mar 7, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 7, 2024
Copy link

github-actions bot commented Mar 7, 2024

@matticbot
Copy link
Contributor

matticbot commented Mar 7, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~174 bytes added 📈 [gzipped])

name       parsed_size           gzip_size
marketing       +447 B  (+0.1%)     +174 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@andrii-lysenko andrii-lysenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable and intuitive for me 👍

@jeherve jeherve merged commit b235ab2 into trunk Mar 11, 2024
13 checks passed
@jeherve jeherve deleted the update/sharing-block-check branch March 11, 2024 17:16
@github-actions github-actions bot removed [Status] In Progress [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 11, 2024
@a8ci18n
Copy link

a8ci18n commented Mar 11, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/11592784

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @jeherve for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Mar 16, 2024

Translation for this Pull Request has now been finished.

billrobbins pushed a commit that referenced this pull request Mar 20, 2024
* Sharing buttons: display block interface when block is supported

Until now this was behind a flag. Let's instead display it all the time, as long as you use either WordPress.com or a version of Jetpack that includes the block.

* Display link to support docs in block button screen

* Add logic to offering disabling the legacy sharing feature

* fix module deactivation

* Add missing block theme check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Sharing Features and settings for sharing posts across different platforms, including sharing buttons. [Pri] Normal [Type] Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants