Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stale naming of hashes and clean up hash functions in L2Block #4844

Closed
benesjan opened this issue Feb 28, 2024 · 0 comments · Fixed by #4984
Closed

Update stale naming of hashes and clean up hash functions in L2Block #4844

benesjan opened this issue Feb 28, 2024 · 0 comments · Fixed by #4984
Assignees
@LHerskind

Comments

@benesjan
Copy link
Contributor

benesjan commented Feb 28, 2024 •
edited by LHerskind
Loading

With the changes for message boxed related to #4492, we no longer just have one commitment to data.

To improve clarity, the current calldataHash is replaced with txs_effects_hash (formerly known as txs_hash).

Furthermore, some of the hashing functionality of the L2Block is now stale and unused, and therefore be removed.

Look for "TODO(#4844)" in the codebase.
@benesjan benesjan mentioned this issue Feb 28, 2024
Merged
@LHerskind LHerskind self-assigned this Mar 6, 2024
@LHerskind LHerskind mentioned this issue Mar 6, 2024
Merged
LHerskind added a commit that referenced this issue Mar 7, 2024
@LHerskind
chore: purging calldata hash (#4984)
f6f34b7 
Fixes #4844.

Purges calldata hash and txs hash to replace both with txs effects hash.

Also moves the compute tx effects hash function from the base rollup and
into the components as was the intention.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LHerskind LHerskind

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: purging calldata hash AztecProtocol/aztec-packages
2 participants
@benesjan @LHerskind