chore: purging calldata hash

[LHerskind]

Fixes #4844.

Purges calldata hash and txs hash to replace both with txs effects hash.

Also moves the compute tx effects hash function from the base rollup and into the components as was the intention.

[LHerskind]

• chore: purging calldata hash #4984 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @LHerskind and the rest of your teammates on Graphite

[AztecBot]

Docs Preview

Hey there! 👋 You can check your preview at https://65e8ad8653244b26444ffc29--aztec-docs-dev.netlify.app

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_trial_decrypting_time_in_ms (8): 7.85 (-93%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 87081317 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,700	18,884	36,452
l1_rollup_calldata_gas	66,516	239,432	469,940
l1_rollup_execution_gas	194,464	500,738	909,198
l2_block_processing_time_in_ms	1,180 (-1%)	4,469 (-1%)	8,885
note_successful_decrypting_time_in_ms	199	540 (-2%)	985 (-1%)
note_trial_decrypting_time_in_ms	⚠️ 7.85 (-93%)	62.9 (-3%)	120 (-5%)
l2_block_building_time_in_ms	16,273 (-1%)	64,818 (-1%)	129,884
l2_block_rollup_simulation_time_in_ms	12,405 (-1%)	49,386 (-1%)	99,171
l2_block_public_tx_process_time_in_ms	3,840	15,349	30,583

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,419	27,792 (+5%)
note_history_successful_decrypting_time_in_ms	1,266 (+1%)	2,433 (+2%)
note_history_trial_decrypting_time_in_ms	113 (+16%)	133 (+1%)
node_database_size_in_bytes	18,788,432	35,496,016
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	250	44,736	28,001
private-kernel-ordering	192	52,625	14,627
base-rollup	1,354 (+2%)	177,932	997
root-rollup	73.1 (+1%)	4,320	825
private-kernel-inner	318 (-1%)	73,715	28,001
public-kernel-app-logic	200 (+3%)	32,254	25,379
merge-rollup	8.72 (+1%)	2,840	997

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.80	10.9 (-2%)	16.6 (+13%)	16.1	25.0 (+11%)	36.2 (+3%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	79.0	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.569	0.608 (-2%)	0.707 (+13%)	0.498	0.521 (+11%)	0.450 (+2%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	45.7	72.1 (-1%)	229	445 (+1%)	871	1,723
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	96.0	159	543	1,055	2,079	4,127
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.468	0.445 (-1%)	0.418	0.417 (+1%)	0.415	0.413
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	54.0	107	337 (-1%)	661 (+1%)	1,310	2,607
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	104	207	691	1,363	2,707	5,395
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.480	0.481 (-1%)	0.456	0.455	0.454	0.453
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	61.0	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	109	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	0.534	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts
tx_size_in_bytes	19,179

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	2,618 (-2%)	1,369

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	0.0273 (-14%)	488 (+2%)

[sklppy88]

Have some super tiny nits but looks good !