-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bb): wasmtime and remote benchmarking #4204
Merged
Merged
Changes from 14 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
7dea003
feat: initial bb wasmtime running again
ludamad0 0d5bb36
proof of concept, running benchmark
ludamad0 9a771a2
feat: wasm-bench preset
ludamad0 d25785a
wasm benchmarking hacks
ludamad0 47439bd
feat: benchmark script
ludamad0 368b7cb
revert: use parallel_for_mutex_pool
ludamad0 91d22d0
hack the cores
ludamad0 c4500f9
fix: google benchmark commits
ludamad0 388b059
fuzzing simplification
ludamad0 d06b016
refactor: standardize benchmarking
ludamad0 9d84372
fix: manual bench mains
ludamad0 688462e
fix: remove main.cpp's for bench
ludamad0 d6a54fc
whitespace
ludamad0 8a51141
Revert readme
ludamad0 0f2cf85
fix: prootogalaxy_bench
ludamad0 0b76a39
fix: forgotten file
ludamad0 014b821
revert
ludamad 79910e7
new-style cli
ludamad0 0e3707d
feat: remote benchmarking scripts
ludamad0 01550af
feat: fixed remote scripts
ludamad0 6f82415
feat: fixed remote scripts
ludamad0 5fe02b7
fix wasm remote
ludamad0 d669b6e
Merge branch 'master' into feat/wasm-bench
ludamad 1e7eb21
Update protocol-circuits-gate-diff.yml
ludamad 3119b45
feat: initial bb wasmtime running again
ludamad0 a32630a
proof of concept, running benchmark
ludamad0 1518fa8
feat: wasm-bench preset
ludamad0 ebd9d11
wasm benchmarking hacks
ludamad0 334b970
feat: benchmark script
ludamad0 6b3ff95
revert: use parallel_for_mutex_pool
ludamad0 21d0fec
hack the cores
ludamad0 09a65d4
fix: google benchmark commits
ludamad0 3ba9ef7
fuzzing simplification
ludamad0 401dce4
refactor: standardize benchmarking
ludamad0 b73eeeb
fix: manual bench mains
ludamad0 ef62c2a
fix: remove main.cpp's for bench
ludamad0 0193829
whitespace
ludamad0 57e1e26
Revert readme
ludamad0 7d18ef1
fix: prootogalaxy_bench
ludamad0 98dfa7f
fix: forgotten file
ludamad0 d61a73d
revert
ludamad 610f51a
new-style cli
ludamad0 2e37e8c
feat: remote benchmarking scripts
ludamad0 7d527cb
feat: fixed remote scripts
ludamad0 f5d76a8
feat: fixed remote scripts
ludamad0 8ea2ff7
fix wasm remote
ludamad0 666ad69
fix: publish bb
ludamad0 b6327eb
Merge remote-tracking branch 'origin/feat/wasm-bench' into feat/wasm-…
ludamad0 f16d21a
Revert
ludamad0 b0f3f53
LOCKING
ludamad0 f57f1fb
Add command option
ludamad0 55401dd
Update gtest.cmake
ludamad 99b3123
Merge branch 'master' into feat/wasm-bench
ludamad 2d8117f
revert
ludamad0 9ee594e
Merge branch 'master' into feat/wasm-bench
ludamad 78a45e7
Merge remote-tracking branch 'origin/feat/wasm-bench' into feat/wasm-…
ludamad0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,19 @@ | ||
if(NOT TESTING) | ||
set(BENCHMARKS OFF) | ||
endif() | ||
|
||
if(BENCHMARKS) | ||
include(FetchContent) | ||
include(FetchContent) | ||
|
||
FetchContent_Declare( | ||
benchmark | ||
GIT_REPOSITORY https://github.com/google/benchmark | ||
GIT_TAG v1.7.1 | ||
FIND_PACKAGE_ARGS | ||
) | ||
FetchContent_Declare( | ||
benchmark | ||
GIT_REPOSITORY https://github.com/AztecProtocol/google-benchmark | ||
GIT_TAG 7638387d2727853d970fc9420dcf95cf3e9bd112 | ||
FIND_PACKAGE_ARGS | ||
) | ||
|
||
set(BENCHMARK_ENABLE_TESTING OFF CACHE BOOL "Benchmark tests off") | ||
set(BENCHMARK_ENABLE_INSTALL OFF CACHE BOOL "Benchmark installation off") | ||
set(BENCHMARK_ENABLE_TESTING OFF CACHE BOOL "Benchmark tests off") | ||
set(BENCHMARK_ENABLE_INSTALL OFF CACHE BOOL "Benchmark installation off") | ||
|
||
FetchContent_MakeAvailable(benchmark) | ||
if(NOT benchmark_FOUND) | ||
# FetchContent_MakeAvailable calls FetchContent_Populate if `find_package` is unsuccessful | ||
# so these variables will be available if we reach this case | ||
set_property(DIRECTORY ${benchmark_SOURCE_DIR} PROPERTY EXCLUDE_FROM_ALL) | ||
set_property(DIRECTORY ${benchmark_BINARY_DIR} PROPERTY EXCLUDE_FROM_ALL) | ||
endif() | ||
FetchContent_MakeAvailable(benchmark) | ||
if(NOT benchmark_FOUND) | ||
# FetchContent_MakeAvailable calls FetchContent_Populate if `find_package` is unsuccessful | ||
# so these variables will be available if we reach this case | ||
set_property(DIRECTORY ${benchmark_SOURCE_DIR} PROPERTY EXCLUDE_FROM_ALL) | ||
set_property(DIRECTORY ${benchmark_BINARY_DIR} PROPERTY EXCLUDE_FROM_ALL) | ||
endif() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,51 +1,51 @@ | ||
if(TESTING) | ||
include(GoogleTest) | ||
include(FetchContent) | ||
|
||
FetchContent_Declare( | ||
GTest | ||
GIT_REPOSITORY https://github.com/google/googletest.git | ||
# Version 1.12.1 is not compatible with WASI-SDK 12 | ||
GIT_TAG release-1.10.0 | ||
FIND_PACKAGE_ARGS | ||
include(GoogleTest) | ||
include(FetchContent) | ||
|
||
FetchContent_Declare( | ||
GTest | ||
GIT_REPOSITORY https://github.com/google/googletest.git | ||
# Version 1.12.1 is not compatible with WASI-SDK 12 | ||
GIT_TAG release-1.10.0 | ||
FIND_PACKAGE_ARGS | ||
) | ||
|
||
set(BUILD_GMOCK OFF CACHE BOOL "Build with gMock disabled") | ||
set(INSTALL_GTEST OFF CACHE BOOL "gTest installation disabled") | ||
# # TODO only in wasm? | ||
# set(gtest_disable_pthreads OFF CACHE BOOL "gTest pthreads disabled") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Stray TODO. I assume you want to delete the |
||
|
||
FetchContent_MakeAvailable(GTest) | ||
|
||
if (NOT GTest_FOUND) | ||
# FetchContent_MakeAvailable calls FetchContent_Populate if `find_package` is unsuccessful | ||
# so these variables will be available if we reach this case | ||
set_property(DIRECTORY ${gtest_SOURCE_DIR} PROPERTY EXCLUDE_FROM_ALL) | ||
set_property(DIRECTORY ${gtest_BINARY_DIR} PROPERTY EXCLUDE_FROM_ALL) | ||
|
||
# Disable all warning when compiling gtest | ||
target_compile_options( | ||
gtest | ||
PRIVATE | ||
-w | ||
) | ||
|
||
set(BUILD_GMOCK OFF CACHE BOOL "Build with gMock disabled") | ||
set(INSTALL_GTEST OFF CACHE BOOL "gTest installation disabled") | ||
|
||
FetchContent_MakeAvailable(GTest) | ||
|
||
if (NOT GTest_FOUND) | ||
# FetchContent_MakeAvailable calls FetchContent_Populate if `find_package` is unsuccessful | ||
# so these variables will be available if we reach this case | ||
set_property(DIRECTORY ${gtest_SOURCE_DIR} PROPERTY EXCLUDE_FROM_ALL) | ||
set_property(DIRECTORY ${gtest_BINARY_DIR} PROPERTY EXCLUDE_FROM_ALL) | ||
|
||
# Disable all warning when compiling gtest | ||
target_compile_options( | ||
if(WASM) | ||
target_compile_definitions( | ||
gtest | ||
PRIVATE | ||
-w | ||
) | ||
|
||
if(WASM) | ||
target_compile_definitions( | ||
gtest | ||
PRIVATE | ||
-DGTEST_HAS_EXCEPTIONS=0 | ||
-DGTEST_HAS_STREAM_REDIRECTION=0 | ||
) | ||
endif() | ||
|
||
mark_as_advanced( | ||
BUILD_GMOCK BUILD_GTEST BUILD_SHARED_LIBS | ||
gmock_build_tests gtest_build_samples gtest_build_tests | ||
gtest_disable_pthreads gtest_force_shared_crt gtest_hide_internal_symbols | ||
-DGTEST_HAS_EXCEPTIONS=0 | ||
-DGTEST_HAS_STREAM_REDIRECTION=0 | ||
) | ||
|
||
add_library(GTest::gtest ALIAS gtest) | ||
add_library(GTest::gtest_main ALIAS gtest_main) | ||
endif() | ||
|
||
enable_testing() | ||
mark_as_advanced( | ||
BUILD_GMOCK BUILD_GTEST BUILD_SHARED_LIBS | ||
gmock_build_tests gtest_build_samples gtest_build_tests | ||
gtest_disable_pthreads gtest_force_shared_crt gtest_hide_internal_symbols | ||
) | ||
|
||
add_library(GTest::gtest ALIAS gtest) | ||
add_library(GTest::gtest_main ALIAS gtest_main) | ||
endif() | ||
|
||
enable_testing() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed the TESTING and BENCHMARK options in favour of simplifying the build pipeline, but I'm happy to revert it if desired